From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48200C43381 for ; Fri, 22 Feb 2019 10:29:07 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F177C2081B for ; Fri, 22 Feb 2019 10:29:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F177C2081B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 445SHj1qTtzDqSM for ; Fri, 22 Feb 2019 21:29:05 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 445RNH2zdvzDqLM for ; Fri, 22 Feb 2019 20:47:59 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 445RNH0Xkvz9sN1; Fri, 22 Feb 2019 20:47:59 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 46ee7c3c5212b0f4f8713d60cfd595721efdf0d3 X-Patchwork-Hint: ignore In-Reply-To: <20190215004817.19961-1-oohall@gmail.com> To: Oliver O'Halloran , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Subject: Re: [v2,1/7] powerpc/eeh: Use debugfs_create_u32 for eeh_max_freezes Message-Id: <445RNH0Xkvz9sN1@ozlabs.org> Date: Fri, 22 Feb 2019 20:47:59 +1100 (AEDT) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sbobroff@linux.ibm.com, Oliver O'Halloran Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 2019-02-15 at 00:48:11 UTC, Oliver O'Halloran wrote: > There's no need to the custom getter/setter functions so we should remove > them in favour of using the generic one. While we're here, change the type > of eeh_max_freeze to u32 and print the value in decimal rather than > hex because printing it in hex makes no sense. > > Signed-off-by: Oliver O'Halloran > Reviewed-by: Sam Bobroff Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/46ee7c3c5212b0f4f8713d60cfd59572 cheers