linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Li Yang-r58472" <LeoLi@freescale.com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH v4]: Fix e500 v2 core reboot bug
Date: Wed, 13 Jun 2007 09:55:56 +0200	[thread overview]
Message-ID: <4470838fec2256a98e512486f8486605@kernel.crashing.org> (raw)
In-Reply-To: <989B956029373F45A0B8AF0297081890D2AC84@zch01exm26.fsl.freescale.net>

> It will be good if you do:
> +				printk (KERN_EMERG "Error: reset
> control"
> +					"register not mapped,
> spinning!\n");
>
> Instead of:
> +				printk (KERN_EMERG "Error: reset control
> \
> +					register not mapped,
> spinning!\n");

Except you forgot a space.  Too much whitespace in the
resulting string is bad, but too little doesn't help
either ;-)


Segher

  reply	other threads:[~2007-06-13  7:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13  6:53 [PATCH v4]: Fix e500 v2 core reboot bug Zang Roy-r61911
2007-06-13  7:03 ` Segher Boessenkool
2007-06-13  7:14   ` Zang Roy-r61911
2007-06-13  7:26     ` Segher Boessenkool
2007-06-13  7:43       ` Zang Roy-r61911
2007-06-13  7:49         ` Li Yang-r58472
2007-06-13  7:55           ` Segher Boessenkool [this message]
2007-06-13  8:07             ` Zang Roy-r61911
2007-06-13  8:16               ` Li Yang-r58472
2007-06-13  9:13             ` Zang Roy-r61911
2007-06-14 13:26               ` Kumar Gala
2007-06-13  7:54         ` Segher Boessenkool
2007-06-13  8:27           ` Zang Roy-r61911

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4470838fec2256a98e512486f8486605@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=LeoLi@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).