* Re: [PATCH v6] selftests: add headers_install to lib.mk [not found] ` <20180904104721.27535-1-anders.roxell@linaro.org> @ 2018-09-28 4:52 ` Michael Ellerman 2018-09-28 13:52 ` Shuah Khan 0 siblings, 1 reply; 3+ messages in thread From: Michael Ellerman @ 2018-09-28 4:52 UTC (permalink / raw) To: Anders Roxell, yamada.masahiro, michal.lkml, shuah, bamv2005, brgl, pbonzini, akpm, rppt, aarcange Cc: Anders Roxell, linux-kbuild, netdev, linux-kernel, linux-kselftest, linuxppc-dev [ + linuxppc-dev ] Anders Roxell <anders.roxell@linaro.org> writes: > If the kernel headers aren't installed we can't build all the tests. > Add a new make target rule 'khdr' in the file lib.mk to generate the > kernel headers and that gets include for every test-dir Makefile that > includes lib.mk If the testdir in turn have its own sub-dirs the > top_srcdir needs to be set to the linux-rootdir to be able to generate > the kernel headers. > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > Reviewed-by: Fathi Boudra <fathi.boudra@linaro.org> > --- > > I sent this (v5) a month ago and wondered if it got lost. Resending > unchanged. > > Cheers, > Anders > > Makefile | 14 +------------- > scripts/subarch.include | 13 +++++++++++++ > tools/testing/selftests/android/Makefile | 2 +- > tools/testing/selftests/android/ion/Makefile | 2 ++ > tools/testing/selftests/futex/functional/Makefile | 1 + > tools/testing/selftests/gpio/Makefile | 7 ++----- > tools/testing/selftests/kvm/Makefile | 7 ++----- > tools/testing/selftests/lib.mk | 12 ++++++++++++ > tools/testing/selftests/net/Makefile | 1 + > .../selftests/networking/timestamping/Makefile | 1 + > tools/testing/selftests/vm/Makefile | 4 ---- > 11 files changed, 36 insertions(+), 28 deletions(-) > create mode 100644 scripts/subarch.include This broke all the powerpc selftests :( Why did it go in at rc5? cheers ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v6] selftests: add headers_install to lib.mk 2018-09-28 4:52 ` [PATCH v6] selftests: add headers_install to lib.mk Michael Ellerman @ 2018-09-28 13:52 ` Shuah Khan 2018-10-02 14:12 ` Michael Ellerman 0 siblings, 1 reply; 3+ messages in thread From: Shuah Khan @ 2018-09-28 13:52 UTC (permalink / raw) To: Michael Ellerman, Anders Roxell, yamada.masahiro, michal.lkml, bamv2005, brgl, pbonzini, akpm, rppt, aarcange Cc: linux-kbuild, netdev, linuxppc-dev, linux-kernel, linux-kselftest, Shuah Khan On 09/27/2018 10:52 PM, Michael Ellerman wrote: > [ + linuxppc-dev ] > > Anders Roxell <anders.roxell@linaro.org> writes: >> If the kernel headers aren't installed we can't build all the tests. >> Add a new make target rule 'khdr' in the file lib.mk to generate the >> kernel headers and that gets include for every test-dir Makefile that >> includes lib.mk If the testdir in turn have its own sub-dirs the >> top_srcdir needs to be set to the linux-rootdir to be able to generate >> the kernel headers. >> >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> Reviewed-by: Fathi Boudra <fathi.boudra@linaro.org> >> --- >> >> I sent this (v5) a month ago and wondered if it got lost. Resending >> unchanged. >> >> Cheers, >> Anders >> >> Makefile | 14 +------------- >> scripts/subarch.include | 13 +++++++++++++ >> tools/testing/selftests/android/Makefile | 2 +- >> tools/testing/selftests/android/ion/Makefile | 2 ++ >> tools/testing/selftests/futex/functional/Makefile | 1 + >> tools/testing/selftests/gpio/Makefile | 7 ++----- >> tools/testing/selftests/kvm/Makefile | 7 ++----- >> tools/testing/selftests/lib.mk | 12 ++++++++++++ >> tools/testing/selftests/net/Makefile | 1 + >> .../selftests/networking/timestamping/Makefile | 1 + >> tools/testing/selftests/vm/Makefile | 4 ---- >> 11 files changed, 36 insertions(+), 28 deletions(-) >> create mode 100644 scripts/subarch.include > > This broke all the powerpc selftests :( Sorry for thr breakage. > > Why did it go in at rc5? > This patch has been in linux-next for a sometime before I decided to send this. My original intent was to send this for rc2, and my schedule was messed up with traveling. Since I didn't hear any issues from linux-next soaking, I made a call on sending this in for rc5. On second thought I should have waited until 4.20. Sorry about that. thanks, -- Shuah ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v6] selftests: add headers_install to lib.mk 2018-09-28 13:52 ` Shuah Khan @ 2018-10-02 14:12 ` Michael Ellerman 0 siblings, 0 replies; 3+ messages in thread From: Michael Ellerman @ 2018-10-02 14:12 UTC (permalink / raw) To: Shuah Khan, Anders Roxell, yamada.masahiro, michal.lkml, bamv2005, brgl, pbonzini, akpm, rppt, aarcange Cc: linux-kbuild, netdev, linuxppc-dev, linux-kernel, linux-kselftest, Shuah Khan Shuah Khan <shuah@kernel.org> writes: > On 09/27/2018 10:52 PM, Michael Ellerman wrote: >> [ + linuxppc-dev ] >> >> Anders Roxell <anders.roxell@linaro.org> writes: >>> If the kernel headers aren't installed we can't build all the tests. >>> Add a new make target rule 'khdr' in the file lib.mk to generate the >>> kernel headers and that gets include for every test-dir Makefile that >>> includes lib.mk If the testdir in turn have its own sub-dirs the >>> top_srcdir needs to be set to the linux-rootdir to be able to generate >>> the kernel headers. >>> >>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >>> Reviewed-by: Fathi Boudra <fathi.boudra@linaro.org> >>> --- >>> >>> I sent this (v5) a month ago and wondered if it got lost. Resending >>> unchanged. >>> >>> Cheers, >>> Anders >>> >>> Makefile | 14 +------------- >>> scripts/subarch.include | 13 +++++++++++++ >>> tools/testing/selftests/android/Makefile | 2 +- >>> tools/testing/selftests/android/ion/Makefile | 2 ++ >>> tools/testing/selftests/futex/functional/Makefile | 1 + >>> tools/testing/selftests/gpio/Makefile | 7 ++----- >>> tools/testing/selftests/kvm/Makefile | 7 ++----- >>> tools/testing/selftests/lib.mk | 12 ++++++++++++ >>> tools/testing/selftests/net/Makefile | 1 + >>> .../selftests/networking/timestamping/Makefile | 1 + >>> tools/testing/selftests/vm/Makefile | 4 ---- >>> 11 files changed, 36 insertions(+), 28 deletions(-) >>> create mode 100644 scripts/subarch.include >> >> This broke all the powerpc selftests :( > > Sorry for thr breakage. > >> Why did it go in at rc5? > > This patch has been in linux-next for a sometime before I decided to send this. > My original intent was to send this for rc2, and my schedule was messed up with > traveling. Since I didn't hear any issues from linux-next soaking, I made a call > on sending this in for rc5. OK. And I didn't notice the breakage in linux-next because _I_ was travelling :) > On second thought I should have waited until 4.20. Sorry about that. Yeah that would have been better, no worries. cheers ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-02 14:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180809080402.24469-1-anders.roxell@linaro.org>
[not found] ` <20180904104721.27535-1-anders.roxell@linaro.org>
2018-09-28 4:52 ` [PATCH v6] selftests: add headers_install to lib.mk Michael Ellerman
2018-09-28 13:52 ` Shuah Khan
2018-10-02 14:12 ` Michael Ellerman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).