From: Tejun Heo <htejun@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, jgarzik@pobox.com
Subject: Re: [PATCH 2.6.16.16] sata_sil24: SII3124 sata driver endian problem
Date: Mon, 05 Jun 2006 05:24:29 +0900 [thread overview]
Message-ID: <4483417D.8060109@gmail.com> (raw)
In-Reply-To: <20060604161124.GA7587@martell.zuzino.mipt.ru>
Alexey Dobriyan wrote:
> Are there some other fields that should be marked?
Yeap, prot and rx_cnt of sil24_prb should also be marked __le. Also,
all fields of sil24_port_multiplier
Thanks.
> [PATCH] sata_sil24: endian annotations
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> drivers/scsi/sata_sil24.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> --- a/drivers/scsi/sata_sil24.c
> +++ b/drivers/scsi/sata_sil24.c
> @@ -37,7 +37,7 @@
> * Port request block (PRB) 32 bytes
> */
> struct sil24_prb {
> - u16 ctrl;
> + __le16 ctrl;
> u16 prot;
> u32 rx_cnt;
> u8 fis[6 * 4];
> @@ -47,9 +47,9 @@ struct sil24_prb {
> * Scatter gather entry (SGE) 16 bytes
> */
> struct sil24_sge {
> - u64 addr;
> - u32 cnt;
> - u32 flags;
> + __le64 addr;
> + __le32 cnt;
> + __le32 flags;
> };
>
> /*
--
tejun
prev parent reply other threads:[~2006-06-04 20:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-01 21:10 SII3124-2 Rune Torgersen
2006-06-02 20:19 ` [PATCH 2.6.16.16] sata_sil24: SII3124 sata driver endian problem Rune Torgersen
2006-06-02 23:30 ` Andrew Morton
2006-06-04 16:11 ` Alexey Dobriyan
2006-06-04 20:24 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4483417D.8060109@gmail.com \
--to=htejun@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).