From: Xianghua Xiao <x.xiao@freescale.com>
To: Jon Loeliger <jdl@jdl.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 5/10 v2] Add 8641 CPU and i8259 Setup
Date: Fri, 09 Jun 2006 12:16:17 -0500 [thread overview]
Message-ID: <4489ACE1.1010803@freescale.com> (raw)
In-Reply-To: <E1FojUI-0004N5-E7@jdl.com>
Jon Loeliger wrote:
>So, like, the other day Benjamin Herrenschmidt mumbled:
>
>
>>[A bunch of SMP issues.]
>>
>>The above is wrong, it prevents using the same kernel image on another
>>platform.
>>
>>
>
>
>
>>Same comment above... #ifdef is bad. You are entering from 0x100 with
>>address translation not disabled ?
>>
>>
>
>
>
>>>+ bl clear_bats
>>> bl load_up_mmu
>>>
>>>
>>Why do you need to call clear_bats here ? load_up_mmu should load BATs.
>>If it doesn't handle the high BATs, then fix it :)
>>
>>
>
>
>
I will fix this...
>>>+#ifdef CONFIG_I8259_LEVEL_TRIGGER
>>>+ outb(0xfa, 0x4d0); /* level triggered */
>>>+ outb(0xde, 0x4d1);
>>>+#endif
>>>
>>>
>>Another change that breaks multiplatform... Can you explain precisely
>>what you are trying to acheive here ? If necessary, we can add an
>>argument to i8259_init. Or you could do the above in your platform
>>code ... though I agree it would be a bit ugly :)
>>
>>
>
>
>
The above code is a must-have on our 8641D HPCN board to get PCI-Express
ULI1575 southbridge going. The 8259(which is residing inside the
southbridge) is collecting all PCI devices' interrupts( from both inside
the ULI1575 and at its external PCI slots) before it reports to MPIC.
PCI interrupts are level-triggered and shared thus we have to configure
8259 to be level-triggered on this particular board.
>OK. I don't have direct answers in hand for some of
>these questions and issues. I'll get with original
>authors and see what we can do clean this up!
>
>Thanks!
>
>jdl
>_______________________________________________
>Linuxppc-dev mailing list
>Linuxppc-dev@ozlabs.org
>https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
>
next prev parent reply other threads:[~2006-06-09 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-08 21:59 [PATCH 5/10 v2] Add 8641 CPU and i8259 Setup Jon Loeliger
2006-06-09 4:23 ` Benjamin Herrenschmidt
2006-06-09 16:05 ` Jon Loeliger
2006-06-09 17:16 ` Xianghua Xiao [this message]
2006-06-14 15:54 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4489ACE1.1010803@freescale.com \
--to=x.xiao@freescale.com \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).