Using bestcomm in an external module (MPC5200B to be exact)

Using bestcomm in an external module (MPC5200B to be exact)

[Trueskew]

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

I'm writing a driver for a TI codec attached to the MPC5200B PSC3 codec
lines on a Lite5200b.  It's an external module, and I'd like to use Bestcomm
with it.  I've already tried a bunch of horrible things to get it to work.
I could say it's close, but by close I mean the FEC still runs, my stuff
doesn't.  
 
1. Can the Bestcomm I/F be used by an external module, or is the module
required to be built in if built-in drivers use Bestcomm?  TasksInitAPI (no
so bad) and TasksLoadImage (yeah, bad) aren't really supposed to be called
more than once from what I've read, and the kernel loads them for ethernet
and ATA (no disk in my system if that matters).  
 
2. If it can be used by an external module, how would I do it?  I've tried
compiling the source into my module and replicating the initialization the
kernel does in addition to my own stuff.  It's not too bad, though I don't
get any interrupts yet.
 
The LTIB from Freescale includes AIC23 and AC97 drivers that use Bestcomm.
I built my kernel with them set as modules, and they had the same unresolved
problems that my driver has on insmod, so I'm pessimistic.  If someone could
put me out of my misery one way or another, I'd appreciate it.
 
Thanks.
Sal
 

[-- Attachment #2: Type: text/html, Size: 2767 bytes --]

Re: Using bestcomm in an external module (MPC5200B to be exact)

[Frank Bennett]

[-- Attachment #1: Type: text/plain, Size: 1990 bytes --]

Trueskew wrote:

> I'm writing a driver for a TI codec attached to the MPC5200B PSC3 
> codec lines on a Lite5200b.  It's an external module, and I'd like to 
> use Bestcomm with it.  I've already tried a bunch of horrible things 
> to get it to work.  I could say it's close, but by close I mean the 
> FEC still runs, my stuff doesn't. 
>  
> 1. Can the Bestcomm I/F be used by an external module, or is the 
> module required to be built in if built-in drivers use Bestcomm?  
> TasksInitAPI (no so bad) and TasksLoadImage (yeah, bad) aren't really 
> supposed to be called more than once from what I've read, and the 
> kernel loads them for ethernet and ATA (no disk in my system if that 
> matters). 
>  
> 2. If it can be used by an external module, how would I do it?  I've 
> tried compiling the source into my module and replicating the 
> initialization the kernel does in addition to my own stuff.  It's not 
> too bad, though I don't get any interrupts yet.
>  
> The LTIB from Freescale includes AIC23 and AC97 drivers that use 
> Bestcomm.  I built my kernel with them set as modules, and they had 
> the same unresolved problems that my driver has on insmod, so I'm 
> pessimistic.  If someone could put me out of my misery one way or 
> another, I'd appreciate it.

Might check out the driver posted by Bob Petersen:
    http://ozlabs.org/pipermail/linuxppc-embedded/2005-September/020210.html
using DENX linuxppc_2_4_devel/arch/ppc/5xxx_io/  i2s.c, psc.c and Bestcomm/

Frank

>  
> Thanks.
> Sal
>  
>
>------------------------------------------------------------------------
>
>_______________________________________________
>Linuxppc-embedded mailing list
>Linuxppc-embedded@ozlabs.org
>https://ozlabs.org/mailman/listinfo/linuxppc-embedded
>
*/Frank Bennett
President/*

Mathegraphics,LLC
613 Bentley Pl
Fort Collins,CO 80526
970-229-9269 (hm) 970-402-9269 (cell)
www.mathegraphics.com <http://www.mathegraphics.com>
bennett78@digis.net <mailto:bennett78@digis.net>


[-- Attachment #2: Type: text/html, Size: 4215 bytes --]

RE: Using bestcomm in an external module (MPC5200B to be exact)

[SalQ]

Thanks Frank, I actually have seen that, but it looks like an internal
module, not an external module... unless I'm missing something.  I've tried
configuring a few drivers that used bestcomm as <M>, and once I used insmod
on them they complained about all of the bestcomm API functions as missing.

________________________________

From: linuxppc-embedded-bounces+salquint=gmail.com@ozlabs.org
[mailto:linuxppc-embedded-bounces+salquint=gmail.com@ozlabs.org] On Behalf
Of Frank Bennett
Sent: Saturday, June 17, 2006 11:53 AM
To: Trueskew
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: Using bestcomm in an external module (MPC5200B to be exact)


Trueskew wrote: 

	I'm writing a driver for a TI codec attached to the MPC5200B PSC3
codec lines on a Lite5200b.  It's an external module, and I'd like to use
Bestcomm with it.  I've already tried a bunch of horrible things to get it
to work.  I could say it's close, but by close I mean the FEC still runs, my
stuff doesn't.  
	 
	1. Can the Bestcomm I/F be used by an external module, or is the
module required to be built in if built-in drivers use Bestcomm?
TasksInitAPI (no so bad) and TasksLoadImage (yeah, bad) aren't really
supposed to be called more than once from what I've read, and the kernel
loads them for ethernet and ATA (no disk in my system if that matters).  
	 
	2. If it can be used by an external module, how would I do it?  I've
tried compiling the source into my module and replicating the initialization
the kernel does in addition to my own stuff.  It's not too bad, though I
don't get any interrupts yet.
	 
	The LTIB from Freescale includes AIC23 and AC97 drivers that use
Bestcomm.  I built my kernel with them set as modules, and they had the same
unresolved problems that my driver has on insmod, so I'm pessimistic.  If
someone could put me out of my misery one way or another, I'd appreciate it.

Might check out the driver posted by Bob Petersen:
    http://ozlabs.org/pipermail/linuxppc-embedded/2005-September/020210.html
using DENX linuxppc_2_4_devel/arch/ppc/5xxx_io/  i2s.c, psc.c and Bestcomm/

Frank


	 
	Thanks.
	Sal
	 
	________________________________


	_______________________________________________
	Linuxppc-embedded mailing list
	Linuxppc-embedded@ozlabs.org
	https://ozlabs.org/mailman/listinfo/linuxppc-embedded

Frank Bennett
President

Mathegraphics,LLC
613 Bentley Pl
Fort Collins,CO 80526
970-229-9269 (hm) 970-402-9269 (cell)
www.mathegraphics.com
bennett78@digis.net

RE: Using bestcomm in an external module (MPC5200B to be exact)

[Trueskew]

I should've let you all know, I'm more of a 2.4 person than a 2.6 person.
So I read what I could on 2.6 difference with 2.4, and it looked like my
easiest choice was to modify the bestcomm code to export a couple tables and
its API functions.  I found that kallsyms has almost all of the functions I
needed to resolve (with 'T' next to them), but they were still not working.
I added EXPORT_MODULE(TaskBDReset) and similar declarations in the bestcomm
api code, but that still didn't do the trick for me.  So what is the trick?
I think I'm on the right track, I can insmod a module that my driver needs,
see kallsyms get updated, and access the functions directly in my driver.  I
hope I'm close to doing something similar with the bestcomm functions, can
anyone offer me some advice on what else I need to do?

Thanks.

________________________________

From: Trueskew [mailto:trueskew@gmail.com] 
Sent: Friday, June 16, 2006 9:47 PM
To: 'linuxppc-embedded@ozlabs.org'
Subject: Using bestcomm in an external module (MPC5200B to be exact)


I'm writing a driver for a TI codec attached to the MPC5200B PSC3 codec
lines on a Lite5200b.  It's an external module, and I'd like to use Bestcomm
with it.  I've already tried a bunch of horrible things to get it to work.
I could say it's close, but by close I mean the FEC still runs, my stuff
doesn't.  
 
1. Can the Bestcomm I/F be used by an external module, or is the module
required to be built in if built-in drivers use Bestcomm?  TasksInitAPI (no
so bad) and TasksLoadImage (yeah, bad) aren't really supposed to be called
more than once from what I've read, and the kernel loads them for ethernet
and ATA (no disk in my system if that matters).  
 
2. If it can be used by an external module, how would I do it?  I've tried
compiling the source into my module and replicating the initialization the
kernel does in addition to my own stuff.  It's not too bad, though I don't
get any interrupts yet.
 
The LTIB from Freescale includes AIC23 and AC97 drivers that use Bestcomm.
I built my kernel with them set as modules, and they had the same unresolved
problems that my driver has on insmod, so I'm pessimistic.  If someone could
put me out of my misery one way or another, I'd appreciate it.
 
Thanks.
Sal

Re: Using bestcomm in an external module (MPC5200B to be exact)

[Andrey Volkov]

Trueskew wrote:
> I should've let you all know, I'm more of a 2.4 person than a 2.6 person.
> So I read what I could on 2.6 difference with 2.4, and it looked like my
> easiest choice was to modify the bestcomm code to export a couple tables and
> its API functions.  I found that kallsyms has almost all of the functions I
> needed to resolve (with 'T' next to them), but they were still not working.
> I added EXPORT_MODULE(TaskBDReset) and similar declarations in the bestcomm
> api code, but that still didn't do the trick for me.  So what is the trick?
> I think I'm on the right track, I can insmod a module that my driver needs,
> see kallsyms get updated, and access the functions directly in my driver.  I
> hope I'm close to doing something similar with the bestcomm functions, can
> anyone offer me some advice on what else I need to do?
> 
> Thanks.
Please, check Sylvain's patchset (http://www.246tNt.com/mpc52xx/)
_before_ you will do anithing. If be more shortly - Freescale's
BestcommAPI _deprecated_ and will _not_ included to 2.6.xxx.

--
Regards
Andrey Volkov


> 
> ________________________________
> 
> From: Trueskew [mailto:trueskew@gmail.com] 
> Sent: Friday, June 16, 2006 9:47 PM
> To: 'linuxppc-embedded@ozlabs.org'
> Subject: Using bestcomm in an external module (MPC5200B to be exact)
> 
> 
> I'm writing a driver for a TI codec attached to the MPC5200B PSC3 codec
> lines on a Lite5200b.  It's an external module, and I'd like to use Bestcomm
> with it.  I've already tried a bunch of horrible things to get it to work.
> I could say it's close, but by close I mean the FEC still runs, my stuff
> doesn't.  
>  
> 1. Can the Bestcomm I/F be used by an external module, or is the module
> required to be built in if built-in drivers use Bestcomm?  TasksInitAPI (no
> so bad) and TasksLoadImage (yeah, bad) aren't really supposed to be called
> more than once from what I've read, and the kernel loads them for ethernet
> and ATA (no disk in my system if that matters).  
>  
> 2. If it can be used by an external module, how would I do it?  I've tried
> compiling the source into my module and replicating the initialization the
> kernel does in addition to my own stuff.  It's not too bad, though I don't
> get any interrupts yet.
>  
> The LTIB from Freescale includes AIC23 and AC97 drivers that use Bestcomm.
> I built my kernel with them set as modules, and they had the same unresolved
> problems that my driver has on insmod, so I'm pessimistic.  If someone could
> put me out of my misery one way or another, I'd appreciate it.
>  
> Thanks.
> Sal
> 
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
> 

RE: Using bestcomm in an external module (MPC5200B to be exact)

[Trueskew]

Hi Andrey,

Thanks for the reply.  I did notice that a few weeks ago and was waiting for
the patch state to be changed from "New" to "Accepted".  Can you give me
more details on how you found out bestcomm won't be included in 2.6?  The
latest downloadable LTIB from Freescale for the Lite5200b includes bestcomm
in several places, and the mpc52xx fec driver uses it, along with the ATA
driver that Sylvain provided a patch for.

As for http://www.246tNt.com/mpc52xx/, it's been coming up "page not found"
for me for those same few weeks when I've tried it off an on, and
www.246tNt.com just has a Welcome line in it.

Sal 

-----Original Message-----
From: Andrey Volkov [mailto:avolkov@varma-el.com] 
Sent: Monday, June 19, 2006 6:15 AM
To: Trueskew
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: Using bestcomm in an external module (MPC5200B to be exact)

Trueskew wrote:
> I should've let you all know, I'm more of a 2.4 person than a 2.6 person.
> So I read what I could on 2.6 difference with 2.4, and it looked like 
> my easiest choice was to modify the bestcomm code to export a couple 
> tables and its API functions.  I found that kallsyms has almost all of 
> the functions I needed to resolve (with 'T' next to them), but they were
still not working.
> I added EXPORT_MODULE(TaskBDReset) and similar declarations in the 
> bestcomm api code, but that still didn't do the trick for me.  So what is
the trick?
> I think I'm on the right track, I can insmod a module that my driver 
> needs, see kallsyms get updated, and access the functions directly in 
> my driver.  I hope I'm close to doing something similar with the 
> bestcomm functions, can anyone offer me some advice on what else I need to
do?
> 
> Thanks.
Please, check Sylvain's patchset (http://www.246tNt.com/mpc52xx/) _before_
you will do anithing. If be more shortly - Freescale's BestcommAPI
_deprecated_ and will _not_ included to 2.6.xxx.

--
Regards
Andrey Volkov


> 
> ________________________________
> 
> From: Trueskew [mailto:trueskew@gmail.com]
> Sent: Friday, June 16, 2006 9:47 PM
> To: 'linuxppc-embedded@ozlabs.org'
> Subject: Using bestcomm in an external module (MPC5200B to be exact)
> 
> 
> I'm writing a driver for a TI codec attached to the MPC5200B PSC3 
> codec lines on a Lite5200b.  It's an external module, and I'd like to 
> use Bestcomm with it.  I've already tried a bunch of horrible things to
get it to work.
> I could say it's close, but by close I mean the FEC still runs, my 
> stuff doesn't.
>  
> 1. Can the Bestcomm I/F be used by an external module, or is the 
> module required to be built in if built-in drivers use Bestcomm?  
> TasksInitAPI (no so bad) and TasksLoadImage (yeah, bad) aren't really 
> supposed to be called more than once from what I've read, and the 
> kernel loads them for ethernet and ATA (no disk in my system if that
matters).
>  
> 2. If it can be used by an external module, how would I do it?  I've 
> tried compiling the source into my module and replicating the 
> initialization the kernel does in addition to my own stuff.  It's not 
> too bad, though I don't get any interrupts yet.
>  
> The LTIB from Freescale includes AIC23 and AC97 drivers that use Bestcomm.
> I built my kernel with them set as modules, and they had the same 
> unresolved problems that my driver has on insmod, so I'm pessimistic.  
> If someone could put me out of my misery one way or another, I'd
appreciate it.
>  
> Thanks.
> Sal
> 
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
> 

Re: Using bestcomm in an external module (MPC5200B to be exact)

[John Rigby]

The next LTIB bsp for 5200b will use the Sylvain's bestcomm api.

On 6/19/06, Trueskew <trueskew@gmail.com> wrote:
> Hi Andrey,
>
> Thanks for the reply.  I did notice that a few weeks ago and was waiting for
> the patch state to be changed from "New" to "Accepted".  Can you give me
> more details on how you found out bestcomm won't be included in 2.6?  The
> latest downloadable LTIB from Freescale for the Lite5200b includes bestcomm
> in several places, and the mpc52xx fec driver uses it, along with the ATA
> driver that Sylvain provided a patch for.
>
> As for http://www.246tNt.com/mpc52xx/, it's been coming up "page not found"
> for me for those same few weeks when I've tried it off an on, and
> www.246tNt.com just has a Welcome line in it.
>
> Sal
>
> -----Original Message-----
> From: Andrey Volkov [mailto:avolkov@varma-el.com]
> Sent: Monday, June 19, 2006 6:15 AM
> To: Trueskew
> Cc: linuxppc-embedded@ozlabs.org
> Subject: Re: Using bestcomm in an external module (MPC5200B to be exact)
>
> Trueskew wrote:
> > I should've let you all know, I'm more of a 2.4 person than a 2.6 person.
> > So I read what I could on 2.6 difference with 2.4, and it looked like
> > my easiest choice was to modify the bestcomm code to export a couple
> > tables and its API functions.  I found that kallsyms has almost all of
> > the functions I needed to resolve (with 'T' next to them), but they were
> still not working.
> > I added EXPORT_MODULE(TaskBDReset) and similar declarations in the
> > bestcomm api code, but that still didn't do the trick for me.  So what is
> the trick?
> > I think I'm on the right track, I can insmod a module that my driver
> > needs, see kallsyms get updated, and access the functions directly in
> > my driver.  I hope I'm close to doing something similar with the
> > bestcomm functions, can anyone offer me some advice on what else I need to
> do?
> >
> > Thanks.
> Please, check Sylvain's patchset (http://www.246tNt.com/mpc52xx/) _before_
> you will do anithing. If be more shortly - Freescale's BestcommAPI
> _deprecated_ and will _not_ included to 2.6.xxx.
>
> --
> Regards
> Andrey Volkov
>
>
> >
> > ________________________________
> >
> > From: Trueskew [mailto:trueskew@gmail.com]
> > Sent: Friday, June 16, 2006 9:47 PM
> > To: 'linuxppc-embedded@ozlabs.org'
> > Subject: Using bestcomm in an external module (MPC5200B to be exact)
> >
> >
> > I'm writing a driver for a TI codec attached to the MPC5200B PSC3
> > codec lines on a Lite5200b.  It's an external module, and I'd like to
> > use Bestcomm with it.  I've already tried a bunch of horrible things to
> get it to work.
> > I could say it's close, but by close I mean the FEC still runs, my
> > stuff doesn't.
> >
> > 1. Can the Bestcomm I/F be used by an external module, or is the
> > module required to be built in if built-in drivers use Bestcomm?
> > TasksInitAPI (no so bad) and TasksLoadImage (yeah, bad) aren't really
> > supposed to be called more than once from what I've read, and the
> > kernel loads them for ethernet and ATA (no disk in my system if that
> matters).
> >
> > 2. If it can be used by an external module, how would I do it?  I've
> > tried compiling the source into my module and replicating the
> > initialization the kernel does in addition to my own stuff.  It's not
> > too bad, though I don't get any interrupts yet.
> >
> > The LTIB from Freescale includes AIC23 and AC97 drivers that use Bestcomm.
> > I built my kernel with them set as modules, and they had the same
> > unresolved problems that my driver has on insmod, so I'm pessimistic.
> > If someone could put me out of my misery one way or another, I'd
> appreciate it.
> >
> > Thanks.
> > Sal
> >
> > _______________________________________________
> > Linuxppc-embedded mailing list
> > Linuxppc-embedded@ozlabs.org
> > https://ozlabs.org/mailman/listinfo/linuxppc-embedded
> >
>
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
>

RE: Using bestcomm in an external module (MPC5200B to be exact)

[Trueskew]

John, would you happen to know where I'd find the latest?  The LTIB I have
is using 
BestComm API v2.2 20041209.

Regards,
Sal

-----Original Message-----
From: John Rigby [mailto:jcrigby@gmail.com] 
Sent: Monday, June 19, 2006 2:33 PM
To: Trueskew
Cc: Andrey Volkov; linuxppc-embedded@ozlabs.org
Subject: Re: Using bestcomm in an external module (MPC5200B to be exact)

The next LTIB bsp for 5200b will use the Sylvain's bestcomm api.

On 6/19/06, Trueskew <trueskew@gmail.com> wrote:
> Hi Andrey,
>
> Thanks for the reply.  I did notice that a few weeks ago and was 
> waiting for the patch state to be changed from "New" to "Accepted".  
> Can you give me more details on how you found out bestcomm won't be 
> included in 2.6?  The latest downloadable LTIB from Freescale for the 
> Lite5200b includes bestcomm in several places, and the mpc52xx fec 
> driver uses it, along with the ATA driver that Sylvain provided a patch
for.
>
> As for http://www.246tNt.com/mpc52xx/, it's been coming up "page not
found"
> for me for those same few weeks when I've tried it off an on, and 
> www.246tNt.com just has a Welcome line in it.
>
> Sal
>
> -----Original Message-----
> From: Andrey Volkov [mailto:avolkov@varma-el.com]
> Sent: Monday, June 19, 2006 6:15 AM
> To: Trueskew
> Cc: linuxppc-embedded@ozlabs.org
> Subject: Re: Using bestcomm in an external module (MPC5200B to be 
> exact)
>
> Trueskew wrote:
> > I should've let you all know, I'm more of a 2.4 person than a 2.6
person.
> > So I read what I could on 2.6 difference with 2.4, and it looked 
> > like my easiest choice was to modify the bestcomm code to export a 
> > couple tables and its API functions.  I found that kallsyms has 
> > almost all of the functions I needed to resolve (with 'T' next to 
> > them), but they were
> still not working.
> > I added EXPORT_MODULE(TaskBDReset) and similar declarations in the 
> > bestcomm api code, but that still didn't do the trick for me.  So 
> > what is
> the trick?
> > I think I'm on the right track, I can insmod a module that my driver 
> > needs, see kallsyms get updated, and access the functions directly 
> > in my driver.  I hope I'm close to doing something similar with the 
> > bestcomm functions, can anyone offer me some advice on what else I 
> > need to
> do?
> >
> > Thanks.
> Please, check Sylvain's patchset (http://www.246tNt.com/mpc52xx/) 
> _before_ you will do anithing. If be more shortly - Freescale's 
> BestcommAPI _deprecated_ and will _not_ included to 2.6.xxx.
>
> --
> Regards
> Andrey Volkov
>
>
> >
> > ________________________________
> >
> > From: Trueskew [mailto:trueskew@gmail.com]
> > Sent: Friday, June 16, 2006 9:47 PM
> > To: 'linuxppc-embedded@ozlabs.org'
> > Subject: Using bestcomm in an external module (MPC5200B to be exact)
> >
> >
> > I'm writing a driver for a TI codec attached to the MPC5200B PSC3 
> > codec lines on a Lite5200b.  It's an external module, and I'd like 
> > to use Bestcomm with it.  I've already tried a bunch of horrible 
> > things to
> get it to work.
> > I could say it's close, but by close I mean the FEC still runs, my 
> > stuff doesn't.
> >
> > 1. Can the Bestcomm I/F be used by an external module, or is the 
> > module required to be built in if built-in drivers use Bestcomm?
> > TasksInitAPI (no so bad) and TasksLoadImage (yeah, bad) aren't 
> > really supposed to be called more than once from what I've read, and 
> > the kernel loads them for ethernet and ATA (no disk in my system if 
> > that
> matters).
> >
> > 2. If it can be used by an external module, how would I do it?  I've 
> > tried compiling the source into my module and replicating the 
> > initialization the kernel does in addition to my own stuff.  It's 
> > not too bad, though I don't get any interrupts yet.
> >
> > The LTIB from Freescale includes AIC23 and AC97 drivers that use
Bestcomm.
> > I built my kernel with them set as modules, and they had the same 
> > unresolved problems that my driver has on insmod, so I'm pessimistic.
> > If someone could put me out of my misery one way or another, I'd
> appreciate it.
> >
> > Thanks.
> > Sal
> >
> > _______________________________________________
> > Linuxppc-embedded mailing list
> > Linuxppc-embedded@ozlabs.org
> > https://ozlabs.org/mailman/listinfo/linuxppc-embedded
> >
>
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
>

RE: Using bestcomm in an external module (MPC5200B to be exact)

[Sylvain Munaut]

> -----Original Message-----
> From: John Rigby [mailto:jcrigby@gmail.com]
> Sent: Monday, June 19, 2006 2:33 PM
> To: Trueskew
> Cc: Andrey Volkov; linuxppc-embedded@ozlabs.org
> Subject: Re: Using bestcomm in an external module (MPC5200B to be exact)
>
> The next LTIB bsp for 5200b will use the Sylvain's bestcomm api.

Cool ;) But it's far from being my whole work. The foundation and a good
cleanup pass comes from Dale and Andrey respectiverly.

Be sure to use the latest one I sent you though ;p
BTW, I guess that means your fine with my last modifications ?


    Sylvain



----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

Re: Using bestcomm in an external module (MPC5200B to be exact)

[John Rigby]

Yes I know its the work of many people,  calling it your was just an
abbreviation.

The latest ltib isn't based on your latest but then again your latest
was never public:).

So is your git tree uptodate?  If so then I will look at putting
together some patches to it.  I have an ata update and also an ac97
driver.  My goal is to have the best version in the public and ltib
just a copy of it.

On 6/20/06, Sylvain Munaut <tnt@246tnt.com> wrote:
>
> > -----Original Message-----
> > From: John Rigby [mailto:jcrigby@gmail.com]
> > Sent: Monday, June 19, 2006 2:33 PM
> > To: Trueskew
> > Cc: Andrey Volkov; linuxppc-embedded@ozlabs.org
> > Subject: Re: Using bestcomm in an external module (MPC5200B to be exact)
> >
> > The next LTIB bsp for 5200b will use the Sylvain's bestcomm api.
>
> Cool ;) But it's far from being my whole work. The foundation and a good
> cleanup pass comes from Dale and Andrey respectiverly.
>
> Be sure to use the latest one I sent you though ;p
> BTW, I guess that means your fine with my last modifications ?
>
>
>     Sylvain
>
>
>
> ----------------------------------------------------------------
> This message was sent using IMP, the Internet Messaging Program.
>
>

RE: Using bestcomm in an external module (MPC5200B to be exact)

[Sylvain Munaut]

Quoting Trueskew <trueskew@gmail.com>:

> Hi Andrey,
>
> Thanks for the reply.  I did notice that a few weeks ago and was waiting f=
or
> the patch state to be changed from "New" to "Accepted".  Can you give me
> more details on how you found out bestcomm won't be included in 2.6?  The
> latest downloadable LTIB from Freescale for the Lite5200b includes bestcom=
m
> in several places, and the mpc52xx fec driver uses it, along with the ATA
> driver that Sylvain provided a patch for.
>
> As for http://www.246tNt.com/mpc52xx/, it's been coming up "page not found=
"
> for me for those same few weeks when I've tried it off an on, and
> www.246tNt.com just has a Welcome line in it.

Yes sorry about that ...
server crash ... hard ... we kinda lost a lot. Hopefully =20
gitbits.246tNt.com which host the bestcomm stuff is on another server.

I also have a newer / cleaner version of the patch. I've sent it to some
dev (Dale, Andrey & John) for comments (any news on that guys ? or are you
just fine with it ?)

But anyway, it's mainly internal cleanup and adapting drivers
from the public version on my git tree to this newest/cleaner
version is a 15 min work ;)


Sylvain



----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

RE: Using bestcomm in an external module (MPC5200B to be exact)

[Benjamin Herrenschmidt]

> But anyway, it's mainly internal cleanup and adapting drivers
> from the public version on my git tree to this newest/cleaner
> version is a 15 min work ;)

Any reason why you aren't regulary submitting those patches for upstream
inclusion ?

Ben.

Re: Using bestcomm in an external module (MPC5200B to be exact)

[Sylvain Munaut]

Benjamin Herrenschmidt wrote:
>> But anyway, it's mainly internal cleanup and adapting drivers
>> from the public version on my git tree to this newest/cleaner
>> version is a 15 min work ;)
>>     
>
> Any reason why you aren't regulary submitting those patches for upstream
> inclusion ?
>   
Yes. What's in there and not in main streams adds quite a lot to
arch/ppc ... So
MPC5200 should be adapted to arch/powerpc first and then those changes.
And since
no-one did that yet and I haven't done it yet either ... (I must admit I
had a quick look
and I didn't understand much on how to do the change ...)


    Sylvain


PS: Sorry for the lag (like 15 days...) you know email
problem/appartement change/vacation/... the usual ;)

Re: Using bestcomm in an external module (MPC5200B to be exact)

[John Rigby]

Sylvain,

How can I help getting the mpc5200 migrated to the powerpc tree?
I should have some time to help with this.

After we get it migrated we can get the bestcomm code in and
the various drivers that use it.

Also, did you ever get a liteb board?  If not send me your address
and I will try again to get you one.

Thanks
John

On 7/17/06, Sylvain Munaut <tnt@246tnt.com> wrote:
> Benjamin Herrenschmidt wrote:
> >> But anyway, it's mainly internal cleanup and adapting drivers
> >> from the public version on my git tree to this newest/cleaner
> >> version is a 15 min work ;)
> >>
> >
> > Any reason why you aren't regulary submitting those patches for upstream
> > inclusion ?
> >
> Yes. What's in there and not in main streams adds quite a lot to
> arch/ppc ... So
> MPC5200 should be adapted to arch/powerpc first and then those changes.
> And since
> no-one did that yet and I haven't done it yet either ... (I must admit I
> had a quick look
> and I didn't understand much on how to do the change ...)
>
>
>     Sylvain
>
>
> PS: Sorry for the lag (like 15 days...) you know email
> problem/appartement change/vacation/... the usual ;)
>
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
>

Re: Using bestcomm in an external module (MPC5200B to be exact)

[Sylvain Munaut]

Hi John,

Frankly ... I don't know, I don't get how this new thing works ...
if you figure it out, be my guest do it and explain it to me ;)

It would be great because I get this cleaned API sitting on my
tree along with the IDE DMA and the FEC code that I'd really
like to send ...

     Sylvain



John Rigby wrote:
> Sylvain,
>
> How can I help getting the mpc5200 migrated to the powerpc tree?
> I should have some time to help with this.
>
> After we get it migrated we can get the bestcomm code in and
> the various drivers that use it.
>
> Also, did you ever get a liteb board?  If not send me your address
> and I will try again to get you one.
>
> Thanks
> John
>
> On 7/17/06, Sylvain Munaut <tnt@246tnt.com> wrote:
>> Benjamin Herrenschmidt wrote:
>> >> But anyway, it's mainly internal cleanup and adapting drivers
>> >> from the public version on my git tree to this newest/cleaner
>> >> version is a 15 min work ;)
>> >>
>> >
>> > Any reason why you aren't regulary submitting those patches for
>> upstream
>> > inclusion ?
>> >
>> Yes. What's in there and not in main streams adds quite a lot to
>> arch/ppc ... So
>> MPC5200 should be adapted to arch/powerpc first and then those changes.
>> And since
>> no-one did that yet and I haven't done it yet either ... (I must admit I
>> had a quick look
>> and I didn't understand much on how to do the change ...)
>>
>>
>>     Sylvain
>>
>>
>> PS: Sorry for the lag (like 15 days...) you know email
>> problem/appartement change/vacation/... the usual ;)
>>
>> _______________________________________________
>> Linuxppc-embedded mailing list
>> Linuxppc-embedded@ozlabs.org
>> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
>>
>