From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Olaf Hering <olh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crash in aty128_set_lcd_enable on PowerBook
Date: Tue, 01 Aug 2006 07:50:35 +0800 [thread overview]
Message-ID: <44CE974B.1090605@gmail.com> (raw)
In-Reply-To: <20060731185024.GA5117@suse.de>
Olaf Hering wrote:
> On Sun, Jul 16, Olaf Hering wrote:
>
>> Current Linus tree crashes in aty128_set_lcd_enable() because par->pdev
>> is NULL. This happens since at least a week. Call trace is:
>>
>> aty128_set_lcd_enable
>> aty128fb_set_par
>> fbcon_init
>> visual_init
>> take_over_console
>> fbcon_takeover
>> notifier_call_chain
>> blocking_notifier_call_chain
>> register_framebuffer
>> aty128fb_probe
>> pci_device_probe
>> bus_for_each_dev
>> driver_attach
>> bus_add_driver
>> driver_register
>> __pci_register_driver
>> aty128fb_init
>> init
>> kernel_thread
>>
>
>
> - info->fix was assigned twice.
> - par->vram_size is assigned in aty128_probe(), no need to redo it again in aty128_init()
> - register_framebuffer() uses uninitialized struct members,
> move it past par->pdev assignment and past aty128_bl_init().
>
>
Looks good.
> Signed-off-by: Olaf Hering <olh@suse.de>
Acked-by: Antonino Daplas <adaplas@pol.net>
prev parent reply other threads:[~2006-07-31 23:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-16 16:37 crash in aty128_set_lcd_enable on PowerBook Olaf Hering
2006-07-16 16:50 ` Olaf Hering
2006-07-16 19:19 ` Benjamin Herrenschmidt
2006-07-16 19:25 ` Benjamin Herrenschmidt
2006-07-16 19:27 ` Olaf Hering
2006-07-16 19:43 ` Benjamin Herrenschmidt
2006-07-16 19:50 ` Olaf Hering
2006-07-31 18:50 ` [PATCH] " Olaf Hering
2006-07-31 23:50 ` Antonino A. Daplas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CE974B.1090605@gmail.com \
--to=adaplas@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).