* [PATCH] ehea: PPC - New hcall opcode defines
@ 2006-08-11 9:40 Thomas Klein
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Klein @ 2006-08-11 9:40 UTC (permalink / raw)
To: linux-ppc; +Cc: Thomas Klein, Christoph Raisch, Marcus Eder, Jan-Bernd Themann
Hi,
this patch adds additional hcall opcode defines in asm-powerpc/hvcall.h
which are required for the IBM eHEA Ethernet Device Driver which is
targeted for kernel inclusion in the near future.
Including those defines in hvcall.h was a request we got in reply to
posting our driver.
Driver post: http://ozlabs.org/pipermail/linuxppc-dev/2006-August/024947.html
Reply: http://ozlabs.org/pipermail/linuxppc-dev/2006-August/024971.html
I'm aware this does not fix a bug and we're already at rc4 but since it
adds only a few innocent defines it would be great if it could be included
in 2.6.18-rc5.
This patch replaces yesterday's patch with the same title. It contains
the modification requested by a comment I got.
Kind regards
Thomas
Signed-off-by: Thomas Klein <tklein@de.ibm.com>
Changelog-by: Thomas Klein <tklein@de.ibm.com>
Differences to patch
http://ozlabs.org/pipermail/linuxppc-dev/2006-August/025000.html
Changelog:
- New defines rearranged according to their numerical value
include/asm-powerpc/hvcall.h | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff -Nurp -X dontdiff linux-2.6.18-rc4/include/asm-powerpc/hvcall.h patched_kernel/include/asm-powerpc/hvcall.h
--- linux-2.6.18-rc4/include/asm-powerpc/hvcall.h 2006-08-06 11:20:11.000000000 -0700
+++ patched_kernel/include/asm-powerpc/hvcall.h 2006-08-11 01:54:49.696514466 -0700
@@ -198,6 +198,19 @@
#define H_MANAGE_TRACE 0x1C0
#define H_QUERY_INT_STATE 0x1E4
#define H_POLL_PENDING 0x1D8
+#define H_MODIFY_HEA_QP 0x250
+#define H_QUERY_HEA_QP 0x254
+#define H_QUERY_HEA 0x258
+#define H_QUERY_HEA_PORT 0x25C
+#define H_MODIFY_HEA_PORT 0x260
+#define H_REG_BCMC 0x264
+#define H_DEREG_BCMC 0x268
+#define H_REGISTER_HEA_RPAGES 0x26C
+#define H_DISABLE_AND_GET_HEA 0x270
+#define H_GET_HEA_INFO 0x274
+#define H_ALLOC_HEA_RESOURCE 0x278
+#define H_ADD_CONN 0x284
+#define H_DEL_CONN 0x288
#define H_JOIN 0x298
#define H_VASI_STATE 0x2A4
#define H_ENABLE_CRQ 0x2B0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ehea: PPC - New hcall opcode defines
@ 2006-08-10 15:05 Thomas Klein
2006-08-10 15:20 ` Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Klein @ 2006-08-10 15:05 UTC (permalink / raw)
To: linux-ppc; +Cc: Thomas Klein, Christoph Raisch, Marcus Eder, Jan-Bernd Themann
Hi,
this patch adds additional hcall opcode defines in asm-powerpc/hvcall.h
which are required for the IBM eHEA Ethernet Device Driver which is
targeted for kernel inclusion in the near future.
Including those defines in hvcall.h was a request we got in reply to
posting our driver.
Driver post: http://ozlabs.org/pipermail/linuxppc-dev/2006-August/024947.html
Reply: http://ozlabs.org/pipermail/linuxppc-dev/2006-August/024971.html
I'm aware this does not fix a bug and we're already at rc4 but since it
adds only a few innocent defines it would be great if it could be included
in 2.6.18-rc5.
Kind regards
Thomas
Signed-off-by: Thomas Klein <tklein@de.ibm.com>
include/asm-powerpc/hvcall.h | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff -Nurp -X dontdiff linux-2.6.18-rc4/include/asm-powerpc/hvcall.h patched_kernel/include/asm-powerpc/hvcall.h
--- linux-2.6.18-rc4/include/asm-powerpc/hvcall.h 2006-08-06 11:20:11.000000000 -0700
+++ patched_kernel/include/asm-powerpc/hvcall.h 2006-08-10 06:26:33.018907062 -0700
@@ -201,6 +201,19 @@
#define H_JOIN 0x298
#define H_VASI_STATE 0x2A4
#define H_ENABLE_CRQ 0x2B0
+#define H_ALLOC_HEA_RESOURCE 0x278
+#define H_MODIFY_HEA_QP 0x250
+#define H_QUERY_HEA_QP 0x254
+#define H_QUERY_HEA 0x258
+#define H_QUERY_HEA_PORT 0x25C
+#define H_MODIFY_HEA_PORT 0x260
+#define H_REG_BCMC 0x264
+#define H_DEREG_BCMC 0x268
+#define H_REGISTER_HEA_RPAGES 0x26C
+#define H_DISABLE_AND_GET_HEA 0x270
+#define H_GET_HEA_INFO 0x274
+#define H_ADD_CONN 0x284
+#define H_DEL_CONN 0x288
#ifndef __ASSEMBLY__
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ehea: PPC - New hcall opcode defines
2006-08-10 15:05 Thomas Klein
@ 2006-08-10 15:20 ` Stephen Rothwell
2006-08-11 9:49 ` Thomas Klein
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2006-08-10 15:20 UTC (permalink / raw)
To: Thomas Klein; +Cc: tklein, linuxppc-dev, raisch, meder, themann
On Thu, 10 Aug 2006 17:05:28 +0200 Thomas Klein <osstklei@de.ibm.com> wrote:
>
> diff -Nurp -X dontdiff linux-2.6.18-rc4/include/asm-powerpc/hvcall.h patched_kernel/include/asm-powerpc/hvcall.h
> --- linux-2.6.18-rc4/include/asm-powerpc/hvcall.h 2006-08-06 11:20:11.000000000 -0700
> +++ patched_kernel/include/asm-powerpc/hvcall.h 2006-08-10 06:26:33.018907062 -0700
> @@ -201,6 +201,19 @@
> #define H_JOIN 0x298
> #define H_VASI_STATE 0x2A4
> #define H_ENABLE_CRQ 0x2B0
> +#define H_ALLOC_HEA_RESOURCE 0x278
> +#define H_MODIFY_HEA_QP 0x250
> +#define H_QUERY_HEA_QP 0x254
> +#define H_QUERY_HEA 0x258
> +#define H_QUERY_HEA_PORT 0x25C
> +#define H_MODIFY_HEA_PORT 0x260
> +#define H_REG_BCMC 0x264
> +#define H_DEREG_BCMC 0x268
> +#define H_REGISTER_HEA_RPAGES 0x26C
> +#define H_DISABLE_AND_GET_HEA 0x270
> +#define H_GET_HEA_INFO 0x274
> +#define H_ADD_CONN 0x284
> +#define H_DEL_CONN 0x288
This patch appears to be whitespace damaged and it would be preferable if
the new defines were in there correct places in numerical order.
Thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ehea: PPC - New hcall opcode defines
2006-08-10 15:20 ` Stephen Rothwell
@ 2006-08-11 9:49 ` Thomas Klein
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Klein @ 2006-08-11 9:49 UTC (permalink / raw)
To: Stephen Rothwell
Cc: tklein, themann, Thomas Klein, linuxppc-dev, raisch, meder
Stephen Rothwell wrote:
> On Thu, 10 Aug 2006 17:05:28 +0200 Thomas Klein <osstklei@de.ibm.com> wrote:
>
>> diff -Nurp -X dontdiff linux-2.6.18-rc4/include/asm-powerpc/hvcall.h patched_kernel/include/asm-powerpc/hvcall.h
>> --- linux-2.6.18-rc4/include/asm-powerpc/hvcall.h 2006-08-06 11:20:11.000000000 -0700
>> +++ patched_kernel/include/asm-powerpc/hvcall.h 2006-08-10 06:26:33.018907062 -0700
>> @@ -201,6 +201,19 @@
>> #define H_JOIN 0x298
>> #define H_VASI_STATE 0x2A4
>> #define H_ENABLE_CRQ 0x2B0
>> +#define H_ALLOC_HEA_RESOURCE 0x278
>> +#define H_MODIFY_HEA_QP 0x250
>> +#define H_QUERY_HEA_QP 0x254
>> +#define H_QUERY_HEA 0x258
>> +#define H_QUERY_HEA_PORT 0x25C
>> +#define H_MODIFY_HEA_PORT 0x260
>> +#define H_REG_BCMC 0x264
>> +#define H_DEREG_BCMC 0x268
>> +#define H_REGISTER_HEA_RPAGES 0x26C
>> +#define H_DISABLE_AND_GET_HEA 0x270
>> +#define H_GET_HEA_INFO 0x274
>> +#define H_ADD_CONN 0x284
>> +#define H_DEL_CONN 0x288
>>
>
> This patch appears to be whitespace damaged and it would be preferable if
> the new defines were in there correct places in numerical order.
>
> Thanks.
>
>
I agree. I posted a new patch
(http://ozlabs.org/pipermail/linuxppc-dev/2006-August/025032.html)
where I rearranged the defines to fit in the numerical order with the
other defines.
The whitespaces are not damaged although they appear to be. This is due
to the usage of
TAB characters to align the hex values. TAB characters are used in the
whole file to align the
numerical values. I applied the patch and the result looks okay.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-08-11 9:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-11 9:40 [PATCH] ehea: PPC - New hcall opcode defines Thomas Klein
-- strict thread matches above, loose matches on Subject: below --
2006-08-10 15:05 Thomas Klein
2006-08-10 15:20 ` Stephen Rothwell
2006-08-11 9:49 ` Thomas Klein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).