From: Jan-Bernd Themann <ossthema@de.ibm.com>
To: michael@ellerman.id.au
Cc: Thomas Klein <tklein@de.ibm.com>, netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Christoph Raisch <raisch@de.ibm.com>,
Anton Blanchard <anton@samba.org>, Marcus Eder <meder@de.ibm.com>
Subject: Re: [PATCH 4/6] ehea: header files
Date: Mon, 14 Aug 2006 08:19:01 +0200 [thread overview]
Message-ID: <44E015D5.8040301@de.ibm.com> (raw)
In-Reply-To: <1155525611.7807.4.camel@localhost.localdomain>
Michael Ellerman wrote:
> On Sat, 2006-08-12 at 07:40 +1000, Anton Blanchard wrote:
>> Hi,
>>
>>> drivers/net/ehea/ehea.h | 452
>>> +#define EHEA_DRIVER_NAME "IBM eHEA"
>> You are using this for ethtool get_drvinfo. Im not sure if it should
>> match the module name, and I worry about having a space in the name. Any
>> ideas on what we should be doing here?
>
> I believe it must match the module name. It also might be nice to call
> it "DRV_NAME" like most other network drivers do.
>
> cheers
>
We rename EHEA_DRIVER_NAME to DRV_NAME (and EHEA_DRIVER_VERSION
to DRV_VERSION) and assign "ehea" to it
Jan-Bernd
next prev parent reply other threads:[~2006-08-14 6:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 8:39 [PATCH 4/6] ehea: header files Jan-Bernd Themann
2006-08-09 13:17 ` Arnd Bergmann
2006-08-10 6:22 ` Michael Ellerman
2006-08-14 12:53 ` Jan-Bernd Themann
2006-08-15 0:08 ` Michael Ellerman
2006-08-15 9:44 ` Jan-Bernd Themann
2006-08-15 10:53 ` Jenkins, Clive
2006-08-15 11:07 ` Christoph Raisch
2006-08-15 11:09 ` edlk4.0 ppc_85xx gdb problems emre kara
2006-08-15 11:46 ` Jenkins, Clive
2006-08-16 0:58 ` [PATCH 4/6] ehea: header files Michael Ellerman
2006-08-11 21:40 ` Anton Blanchard
2006-08-14 3:20 ` Michael Ellerman
2006-08-14 6:19 ` Jan-Bernd Themann [this message]
2006-08-11 22:07 ` Anton Blanchard
2006-08-12 16:40 ` Thomas Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E015D5.8040301@de.ibm.com \
--to=ossthema@de.ibm.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=michael@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=raisch@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).