From: Geoff Levand <geoffrey.levand@am.sony.com>
To: linuxppc-dev@ozlabs.org
Subject: undefined reference to pci_io_base
Date: Tue, 29 Aug 2006 10:34:54 -0700 [thread overview]
Message-ID: <44F47ABE.7080602@am.sony.com> (raw)
I'm trying to understand the intended design of the inb()
and outb() macros in asm-powerpc/io.h. They are causing
me some grief when I set CONFIG_PCI=n:
drivers/built-in.o: undefined reference to `pci_io_base'
This is coming from drivers/char/mem.c, which is always
built in, and is referencing pci_io_base through inb()
and outb().
Anyway, it seems asm-powerpc/io.h has two sets of io macros,
one set for iSeries, and one generic set for everything else.
The problem arises because the generic macros just use the eeh
macros in eeh.h, which in turn, directly use pci_io_base.
I can think of three solutions to this that work for me, but
I'm not sure which, if any, would be the most proper. One
would be to just have this in io.h:
#if defined(CONFI_PCI)
extern unsigned long pci_io_base;
#else
#define pci_io_base 0
#endif
Another would be to have this in some file that is always built
in, like setup-common.c:
#if !defined(CONFI_PCI)
unsigned long pci_io_base;
EXPORT_SYMBOL(pci_io_base);
#endif
A third would be to have another set of io macros in io.h that
are used when CONFIG_PCI=n.
Comments welcome.
-Geoff
next reply other threads:[~2006-08-29 17:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 17:34 Geoff Levand [this message]
2006-08-29 20:28 ` undefined reference to pci_io_base Linas Vepstas
2006-08-29 22:38 ` Benjamin Herrenschmidt
2006-08-29 22:42 ` Paul Mackerras
2006-08-29 23:20 ` Linas Vepstas
2006-08-29 23:57 ` Geoff Levand
2006-08-30 0:13 ` Paul Mackerras
2006-08-30 15:05 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F47ABE.7080602@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).