linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc: remove dead code in head_fsl_booke.S
@ 2019-02-28  8:31 Jason Yan
  2019-02-28 13:00 ` Christophe Leroy
  2019-03-14 11:43 ` Michael Ellerman
  0 siblings, 2 replies; 4+ messages in thread
From: Jason Yan @ 2019-02-28  8:31 UTC (permalink / raw)
  To: benh, paulus, mpe, diana.craciun, christophe.leroy, linuxppc-dev
  Cc: Jason Yan

This code is dead. Just remove it.

Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 arch/powerpc/kernel/head_fsl_booke.S | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/kernel/head_fsl_booke.S
index 2386ce2a9c6e..b8450f017d85 100644
--- a/arch/powerpc/kernel/head_fsl_booke.S
+++ b/arch/powerpc/kernel/head_fsl_booke.S
@@ -194,13 +194,6 @@ set_ivor:
 #endif
 	mtspr	SPRN_MAS4, r2
 
-#if 0
-	/* Enable DOZE */
-	mfspr	r2,SPRN_HID0
-	oris	r2,r2,HID0_DOZE@h
-	mtspr	SPRN_HID0, r2
-#endif
-
 #if !defined(CONFIG_BDI_SWITCH)
 	/*
 	 * The Abatron BDI JTAG debugger does not tolerate others
-- 
2.14.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] powerpc: remove dead code in head_fsl_booke.S
  2019-02-28  8:31 [PATCH] powerpc: remove dead code in head_fsl_booke.S Jason Yan
@ 2019-02-28 13:00 ` Christophe Leroy
  2019-03-04  1:28   ` Jason Yan
  2019-03-14 11:43 ` Michael Ellerman
  1 sibling, 1 reply; 4+ messages in thread
From: Christophe Leroy @ 2019-02-28 13:00 UTC (permalink / raw)
  To: Jason Yan, benh, paulus, mpe, diana.craciun, linuxppc-dev



Le 28/02/2019 à 09:31, Jason Yan a écrit :
> This code is dead. Just remove it.
> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>

This review was easy :)

Christophe

> ---
>   arch/powerpc/kernel/head_fsl_booke.S | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/kernel/head_fsl_booke.S
> index 2386ce2a9c6e..b8450f017d85 100644
> --- a/arch/powerpc/kernel/head_fsl_booke.S
> +++ b/arch/powerpc/kernel/head_fsl_booke.S
> @@ -194,13 +194,6 @@ set_ivor:
>   #endif
>   	mtspr	SPRN_MAS4, r2
>   
> -#if 0
> -	/* Enable DOZE */
> -	mfspr	r2,SPRN_HID0
> -	oris	r2,r2,HID0_DOZE@h
> -	mtspr	SPRN_HID0, r2
> -#endif
> -
>   #if !defined(CONFIG_BDI_SWITCH)
>   	/*
>   	 * The Abatron BDI JTAG debugger does not tolerate others
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] powerpc: remove dead code in head_fsl_booke.S
  2019-02-28 13:00 ` Christophe Leroy
@ 2019-03-04  1:28   ` Jason Yan
  0 siblings, 0 replies; 4+ messages in thread
From: Jason Yan @ 2019-03-04  1:28 UTC (permalink / raw)
  To: Christophe Leroy, benh, paulus, mpe, diana.craciun, linuxppc-dev



On 2019/2/28 21:00, Christophe Leroy wrote:
> 
> 
> Le 28/02/2019 à 09:31, Jason Yan a écrit :
>> This code is dead. Just remove it.
>>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> 
> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> 
> This review was easy :)
> 
> Christophe
> 

Christophe, thanks.


>> ---
>>   arch/powerpc/kernel/head_fsl_booke.S | 7 -------
>>   1 file changed, 7 deletions(-)
>>
>> diff --git a/arch/powerpc/kernel/head_fsl_booke.S 
>> b/arch/powerpc/kernel/head_fsl_booke.S
>> index 2386ce2a9c6e..b8450f017d85 100644
>> --- a/arch/powerpc/kernel/head_fsl_booke.S
>> +++ b/arch/powerpc/kernel/head_fsl_booke.S
>> @@ -194,13 +194,6 @@ set_ivor:
>>   #endif
>>       mtspr    SPRN_MAS4, r2
>> -#if 0
>> -    /* Enable DOZE */
>> -    mfspr    r2,SPRN_HID0
>> -    oris    r2,r2,HID0_DOZE@h
>> -    mtspr    SPRN_HID0, r2
>> -#endif
>> -
>>   #if !defined(CONFIG_BDI_SWITCH)
>>       /*
>>        * The Abatron BDI JTAG debugger does not tolerate others
>>
> 
> .
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: powerpc: remove dead code in head_fsl_booke.S
  2019-02-28  8:31 [PATCH] powerpc: remove dead code in head_fsl_booke.S Jason Yan
  2019-02-28 13:00 ` Christophe Leroy
@ 2019-03-14 11:43 ` Michael Ellerman
  1 sibling, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2019-03-14 11:43 UTC (permalink / raw)
  To: Jason Yan, benh, paulus, diana.craciun, christophe.leroy,
	linuxppc-dev
  Cc: Jason Yan

On Thu, 2019-02-28 at 08:31:21 UTC, Jason Yan wrote:
> This code is dead. Just remove it.
> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/e585f51c4ee00046175ace52ca87ea47

cheers

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-14 11:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-28  8:31 [PATCH] powerpc: remove dead code in head_fsl_booke.S Jason Yan
2019-02-28 13:00 ` Christophe Leroy
2019-03-04  1:28   ` Jason Yan
2019-03-14 11:43 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).