* [PATCH] Disable kcov for slb routines.
@ 2019-03-04 8:25 Mahesh J Salgaonkar
2019-03-05 3:31 ` Andrew Donnellan
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Mahesh J Salgaonkar @ 2019-03-04 8:25 UTC (permalink / raw)
To: linuxppc-dev; +Cc: syzkaller, Paul Mackerras, Nicholas Piggin, Andrew Donnellan
From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
The kcov instrumentation inside SLB routines causes duplicate SLB entries
to be added resulting into SLB multihit machine checks.
Disable kcov instrumentation on slb.o
Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
---
arch/powerpc/mm/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/mm/Makefile b/arch/powerpc/mm/Makefile
index d4d32e229ace..f9cb40684746 100644
--- a/arch/powerpc/mm/Makefile
+++ b/arch/powerpc/mm/Makefile
@@ -60,3 +60,4 @@ obj-$(CONFIG_PPC_MEM_KEYS) += pkeys.o
# This is necessary for booting with kcov enabled on book3e machines
KCOV_INSTRUMENT_tlb_nohash.o := n
KCOV_INSTRUMENT_fsl_booke_mmu.o := n
+KCOV_INSTRUMENT_slb.o := n
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Disable kcov for slb routines.
2019-03-04 8:25 [PATCH] Disable kcov for slb routines Mahesh J Salgaonkar
@ 2019-03-05 3:31 ` Andrew Donnellan
2019-03-07 4:37 ` Satheesh Rajendran
2019-03-14 11:43 ` Michael Ellerman
2 siblings, 0 replies; 6+ messages in thread
From: Andrew Donnellan @ 2019-03-05 3:31 UTC (permalink / raw)
To: Mahesh J Salgaonkar, linuxppc-dev
Cc: syzkaller, Paul Mackerras, Nicholas Piggin, Andrew Donnellan
On 4/3/19 7:25 pm, Mahesh J Salgaonkar wrote:
> From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>
> The kcov instrumentation inside SLB routines causes duplicate SLB entries
> to be added resulting into SLB multihit machine checks.
> Disable kcov instrumentation on slb.o
>
> Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Summary line needs a powerpc:
> ---
> arch/powerpc/mm/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/mm/Makefile b/arch/powerpc/mm/Makefile
> index d4d32e229ace..f9cb40684746 100644
> --- a/arch/powerpc/mm/Makefile
> +++ b/arch/powerpc/mm/Makefile
> @@ -60,3 +60,4 @@ obj-$(CONFIG_PPC_MEM_KEYS) += pkeys.o
> # This is necessary for booting with kcov enabled on book3e machines
> KCOV_INSTRUMENT_tlb_nohash.o := n
> KCOV_INSTRUMENT_fsl_booke_mmu.o := n
> +KCOV_INSTRUMENT_slb.o := n
The SLB stuff isn't related to the book3e issues, I'd appreciate a
separate comment here.
Otherwise
Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Disable kcov for slb routines.
2019-03-04 8:25 [PATCH] Disable kcov for slb routines Mahesh J Salgaonkar
2019-03-05 3:31 ` Andrew Donnellan
@ 2019-03-07 4:37 ` Satheesh Rajendran
2019-03-14 11:43 ` Michael Ellerman
2 siblings, 0 replies; 6+ messages in thread
From: Satheesh Rajendran @ 2019-03-07 4:37 UTC (permalink / raw)
To: Mahesh J Salgaonkar
Cc: linuxppc-dev, syzkaller, Paul Mackerras, Nicholas Piggin,
Andrew Donnellan
On Mon, Mar 04, 2019 at 01:55:51PM +0530, Mahesh J Salgaonkar wrote:
> From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>
> The kcov instrumentation inside SLB routines causes duplicate SLB entries
> to be added resulting into SLB multihit machine checks.
> Disable kcov instrumentation on slb.o
>
> Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
> ---
> arch/powerpc/mm/Makefile | 1 +
> 1 file changed, 1 insertion(+)
Fixes: https://github.com/linuxppc/issues/issues/230
Tested-by: Satheesh Rajendran <sathnaga@linux.vent.ibm.com>
>
> diff --git a/arch/powerpc/mm/Makefile b/arch/powerpc/mm/Makefile
> index d4d32e229ace..f9cb40684746 100644
> --- a/arch/powerpc/mm/Makefile
> +++ b/arch/powerpc/mm/Makefile
> @@ -60,3 +60,4 @@ obj-$(CONFIG_PPC_MEM_KEYS) += pkeys.o
> # This is necessary for booting with kcov enabled on book3e machines
> KCOV_INSTRUMENT_tlb_nohash.o := n
> KCOV_INSTRUMENT_fsl_booke_mmu.o := n
> +KCOV_INSTRUMENT_slb.o := n
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Disable kcov for slb routines.
2019-03-04 8:25 [PATCH] Disable kcov for slb routines Mahesh J Salgaonkar
2019-03-05 3:31 ` Andrew Donnellan
2019-03-07 4:37 ` Satheesh Rajendran
@ 2019-03-14 11:43 ` Michael Ellerman
2019-03-15 5:01 ` Mahesh Jagannath Salgaonkar
2 siblings, 1 reply; 6+ messages in thread
From: Michael Ellerman @ 2019-03-14 11:43 UTC (permalink / raw)
To: Mahesh J Salgaonkar, linuxppc-dev
Cc: syzkaller, Paul Mackerras, Nicholas Piggin, Andrew Donnellan
On Mon, 2019-03-04 at 08:25:51 UTC, Mahesh J Salgaonkar wrote:
> From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>
> The kcov instrumentation inside SLB routines causes duplicate SLB entries
> to be added resulting into SLB multihit machine checks.
> Disable kcov instrumentation on slb.o
>
> Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
> Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Tested-by: Satheesh Rajendran <sathnaga@linux.vent.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/19d6907521b04206676741b26e05a152
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Disable kcov for slb routines.
2019-03-14 11:43 ` Michael Ellerman
@ 2019-03-15 5:01 ` Mahesh Jagannath Salgaonkar
2019-03-20 12:51 ` Michael Ellerman
0 siblings, 1 reply; 6+ messages in thread
From: Mahesh Jagannath Salgaonkar @ 2019-03-15 5:01 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev
Cc: syzkaller, Paul Mackerras, Nicholas Piggin, Andrew Donnellan
On 3/14/19 5:13 PM, Michael Ellerman wrote:
> On Mon, 2019-03-04 at 08:25:51 UTC, Mahesh J Salgaonkar wrote:
>> From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>>
>> The kcov instrumentation inside SLB routines causes duplicate SLB entries
>> to be added resulting into SLB multihit machine checks.
>> Disable kcov instrumentation on slb.o
>>
>> Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>> Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>> Tested-by: Satheesh Rajendran <sathnaga@linux.vent.ibm.com>
>
> Applied to powerpc next, thanks.
>
> https://git.kernel.org/powerpc/c/19d6907521b04206676741b26e05a152
>
> cheers
>
There was a v2 at http://patchwork.ozlabs.org/patch/1051718/, looks like
v1 got picked up. But I see the applied commit does address Andrew's
comments.
Thanks,
-Mahesh.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Disable kcov for slb routines.
2019-03-15 5:01 ` Mahesh Jagannath Salgaonkar
@ 2019-03-20 12:51 ` Michael Ellerman
0 siblings, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2019-03-20 12:51 UTC (permalink / raw)
To: Mahesh Jagannath Salgaonkar, Michael Ellerman, linuxppc-dev
Cc: syzkaller, Paul Mackerras, Nicholas Piggin, Andrew Donnellan
Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com> writes:
> On 3/14/19 5:13 PM, Michael Ellerman wrote:
>> On Mon, 2019-03-04 at 08:25:51 UTC, Mahesh J Salgaonkar wrote:
>>> From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>>>
>>> The kcov instrumentation inside SLB routines causes duplicate SLB entries
>>> to be added resulting into SLB multihit machine checks.
>>> Disable kcov instrumentation on slb.o
>>>
>>> Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>>> Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>>> Tested-by: Satheesh Rajendran <sathnaga@linux.vent.ibm.com>
>>
>> Applied to powerpc next, thanks.
>>
>> https://git.kernel.org/powerpc/c/19d6907521b04206676741b26e05a152
>>
>> cheers
>>
>
> There was a v2 at http://patchwork.ozlabs.org/patch/1051718/, looks like
> v1 got picked up. But I see the applied commit does address Andrew's
> comments.
Sorry not sure how I missed v2.
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-20 12:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-04 8:25 [PATCH] Disable kcov for slb routines Mahesh J Salgaonkar
2019-03-05 3:31 ` Andrew Donnellan
2019-03-07 4:37 ` Satheesh Rajendran
2019-03-14 11:43 ` Michael Ellerman
2019-03-15 5:01 ` Mahesh Jagannath Salgaonkar
2019-03-20 12:51 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).