* [PATCH] powerpc/64s: Include <asm/nmi.h> header file to fix a warning
@ 2019-03-12 20:18 Mathieu Malaterre
2019-03-12 21:11 ` Christophe Leroy
2019-03-14 11:43 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Mathieu Malaterre @ 2019-03-12 20:18 UTC (permalink / raw)
To: Michael Ellerman
Cc: Mathieu Malaterre, Paul Mackerras, linuxppc-dev, linux-kernel
Make sure to include <asm/nmi.h> to provide the following prototype:
hv_nmi_check_nonrecoverable.
Remove the following warning treated as error (W=1):
arch/powerpc/kernel/traps.c:393:6: error: no previous prototype for 'hv_nmi_check_nonrecoverable' [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
arch/powerpc/kernel/traps.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
index a21200c6aaea..1fd45a8650e1 100644
--- a/arch/powerpc/kernel/traps.c
+++ b/arch/powerpc/kernel/traps.c
@@ -71,6 +71,7 @@
#include <sysdev/fsl_pci.h>
#include <asm/kprobes.h>
#include <asm/stacktrace.h>
+#include <asm/nmi.h>
#if defined(CONFIG_DEBUGGER) || defined(CONFIG_KEXEC_CORE)
int (*__debugger)(struct pt_regs *regs) __read_mostly;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/64s: Include <asm/nmi.h> header file to fix a warning
2019-03-12 20:18 [PATCH] powerpc/64s: Include <asm/nmi.h> header file to fix a warning Mathieu Malaterre
@ 2019-03-12 21:11 ` Christophe Leroy
2019-03-14 11:43 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Leroy @ 2019-03-12 21:11 UTC (permalink / raw)
To: Mathieu Malaterre, Michael Ellerman
Cc: linuxppc-dev, Paul Mackerras, linux-kernel
Le 12/03/2019 à 21:18, Mathieu Malaterre a écrit :
> Make sure to include <asm/nmi.h> to provide the following prototype:
> hv_nmi_check_nonrecoverable.
>
> Remove the following warning treated as error (W=1):
>
> arch/powerpc/kernel/traps.c:393:6: error: no previous prototype for 'hv_nmi_check_nonrecoverable' [-Werror=missing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> arch/powerpc/kernel/traps.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
> index a21200c6aaea..1fd45a8650e1 100644
> --- a/arch/powerpc/kernel/traps.c
> +++ b/arch/powerpc/kernel/traps.c
> @@ -71,6 +71,7 @@
> #include <sysdev/fsl_pci.h>
> #include <asm/kprobes.h>
> #include <asm/stacktrace.h>
> +#include <asm/nmi.h>
>
> #if defined(CONFIG_DEBUGGER) || defined(CONFIG_KEXEC_CORE)
> int (*__debugger)(struct pt_regs *regs) __read_mostly;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: powerpc/64s: Include <asm/nmi.h> header file to fix a warning
2019-03-12 20:18 [PATCH] powerpc/64s: Include <asm/nmi.h> header file to fix a warning Mathieu Malaterre
2019-03-12 21:11 ` Christophe Leroy
@ 2019-03-14 11:43 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2019-03-14 11:43 UTC (permalink / raw)
To: Mathieu Malaterre
Cc: Mathieu Malaterre, linuxppc-dev, Paul Mackerras, linux-kernel
On Tue, 2019-03-12 at 20:18:23 UTC, Mathieu Malaterre wrote:
> Make sure to include <asm/nmi.h> to provide the following prototype:
> hv_nmi_check_nonrecoverable.
>
> Remove the following warning treated as error (W=1):
>
> arch/powerpc/kernel/traps.c:393:6: error: no previous prototype for 'hv_nmi_check_nonrecoverable' [-Werror=missing-prototypes]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/de3c83c2fd2b87cf68214eda76dfa669
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-14 11:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-12 20:18 [PATCH] powerpc/64s: Include <asm/nmi.h> header file to fix a warning Mathieu Malaterre
2019-03-12 21:11 ` Christophe Leroy
2019-03-14 11:43 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).