From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: diana.craciun@nxp.com, mikey@neuling.org, msuchanek@suse.de,
andrew.donnellan@au1.ibm.com, dja@axtens.net
Subject: Re: powerpc/security: Fix spectre_v2 reporting
Date: Fri, 22 Mar 2019 23:21:41 +1100 (AEDT) [thread overview]
Message-ID: <44QjSj4qcjz9sV3@ozlabs.org> (raw)
In-Reply-To: <20190321042433.20454-1-mpe@ellerman.id.au>
On Thu, 2019-03-21 at 04:24:33 UTC, Michael Ellerman wrote:
> When I updated the spectre_v2 reporting to handle software count cache
> flush I got the logic wrong when there's no software count cache
> enabled at all.
>
> The result is that on systems with the software count cache flush
> disabled we print:
>
> Mitigation: Indirect branch cache disabled, Software count cache flush
>
> Which correctly indicates that the count cache is disabled, but
> incorrectly says the software count cache flush is enabled.
>
> The root of the problem is that we are trying to handle all
> combinations of options. But we know now that we only expect to see
> the software count cache flush enabled if the other options are false.
>
> So split the two cases, which simplifies the logic and fixes the bug.
> We were also missing a space before "(hardware accelerated)".
>
> The result is we see one of:
>
> Mitigation: Indirect branch serialisation (kernel only)
> Mitigation: Indirect branch cache disabled
> Mitigation: Software count cache flush
> Mitigation: Software count cache flush (hardware accelerated)
>
> Fixes: ee13cb249fab ("powerpc/64s: Add support for software count cache flush")
> Cc: stable@vger.kernel.org # v4.19+
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Reviewed-by: Michael Neuling <mikey@neuling.org>
> Reviewed-by: Diana Craciun <diana.craciun@nxp.com>
Applied to powerpc fixes.
https://git.kernel.org/powerpc/c/92edf8df0ff2ae86cc632eeca0e651fd
cheers
prev parent reply other threads:[~2019-03-22 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 4:24 [PATCH] powerpc/security: Fix spectre_v2 reporting Michael Ellerman
2019-03-21 6:29 ` Michael Neuling
2019-03-21 9:59 ` Diana Madalina Craciun
2019-03-22 12:21 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44QjSj4qcjz9sV3@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=andrew.donnellan@au1.ibm.com \
--cc=diana.craciun@nxp.com \
--cc=dja@axtens.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox