From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2747C43381 for ; Sun, 31 Mar 2019 10:14:36 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5891F20882 for ; Sun, 31 Mar 2019 10:14:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5891F20882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44XBCs71hVzDqPg for ; Sun, 31 Mar 2019 21:14:33 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44XBB6759ZzDqNS for ; Sun, 31 Mar 2019 21:13:02 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 44XBB65zQyz9sRW; Sun, 31 Mar 2019 21:13:02 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: ce9afe08e71e3f7d64f337a6e932e50849230fc2 X-Patchwork-Hint: ignore In-Reply-To: <1552059204-18626-1-git-send-email-ego@linux.vnet.ibm.com> To: "Gautham R. Shenoy" , Michael Bringmann , Benjamin Herrenschmidt , Paul Mackerras , Vaidyanathan Srinivasan From: Michael Ellerman Subject: Re: pseries/energy: Use OF accessor functions to read ibm, drc-indexes Message-Id: <44XBB65zQyz9sRW@ozlabs.org> Date: Sun, 31 Mar 2019 21:13:02 +1100 (AEDT) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Pavithra R. Prakash" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Gautham R. Shenoy" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 2019-03-08 at 15:33:24 UTC, "Gautham R. Shenoy" wrote: > From: "Gautham R. Shenoy" > > In cpu_to_drc_index() in the case when FW_FEATURE_DRC_INFO is absent, > we currently use of_read_property() to obtain the pointer to the array > corresponding to the property "ibm,drc-indexes". The elements of this > array are of type __be32, but are accessed without any conversion to > the OS-endianness, which is buggy on a Little Endian OS. > > Fix this by using of_property_read_u32_index() accessor function to > safely read the elements of the array. > > Fixes: commit e83636ac3334 ("pseries/drc-info: Search DRC properties for CPU indexes") > Cc: #v4.16+ > Reported-by: Pavithra R. Prakash > Signed-off-by: Gautham R. Shenoy > Reviewed-by: Vaidyanathan Srinivasan Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/ce9afe08e71e3f7d64f337a6e932e508 cheers