From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: George Spelvin <lkml@sdf.org>, Daniel Axtens <dja@axtens.net>,
linuxppc-dev@lists.ozlabs.org
Cc: George Spelvin <lkml@sdf.org>, Paul Mackerras <paulus@samba.org>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: arch/powerpc/crypto/crc-vpmsum_test: Use cheaper random numbers for self-test
Date: Mon, 22 Apr 2019 00:18:49 +1000 (AEST) [thread overview]
Message-ID: <44nBf21J3Vz9sBr@ozlabs.org> (raw)
In-Reply-To: <201903211042.x2LAgMp3003053@sdf.org>
On Thu, 2019-03-21 at 10:42:22 UTC, George Spelvin wrote:
> This code was filling a 64K buffer from /dev/urandom in order to
> compute a CRC over (on average half of) it by two different methods,
> comparing the CRCs, and repeating.
>
> This is not a remotely security-critical application, so use the far
> faster and cheaper prandom_u32() generator.
>
> And, while we're at it, only fill as much of the buffer as we plan to use.
>
> Signed-off-by: George Spelvin <lkml@sdf.org>
> Cc: Daniel Axtens <dja@axtens.net>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Acked-by: Daniel Axtens <dja@axtens.net>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/80d04b7fabe161a23d143b3bfcfca1b0
cheers
prev parent reply other threads:[~2019-04-21 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 10:42 [PATCH] arch/powerpc/crypto/crc-vpmsum_test: Use cheaper random numbers for self-test George Spelvin
2019-03-22 2:13 ` Daniel Axtens
2019-04-21 14:18 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44nBf21J3Vz9sBr@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=dja@axtens.net \
--cc=herbert@gondor.apana.org.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkml@sdf.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox