From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C1D7C43219 for ; Fri, 3 May 2019 07:03:24 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1AB9205F4 for ; Fri, 3 May 2019 07:03:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1AB9205F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44wNQ161TSzDqQt for ; Fri, 3 May 2019 17:03:21 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44wNK61KvvzDqPW for ; Fri, 3 May 2019 16:59:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 44wNK60Ghwz9sBb; Fri, 3 May 2019 16:59:05 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 860b7d2286236170a36f94946d03ca9888d32571 X-Patchwork-Hint: ignore In-Reply-To: <20181218062041.25198-1-anju@linux.vnet.ibm.com> To: Anju T Sudhakar From: Michael Ellerman Subject: Re: [PATCH v2] powerpc/perf: Fix loop exit condition in nest_imc_event_init Message-Id: <44wNK60Ghwz9sBb@ozlabs.org> Date: Fri, 3 May 2019 16:59:05 +1000 (AEST) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: maddy@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, anju@linux.vnet.ibm.com, dan.carpenter@oracle.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 2018-12-18 at 06:20:41 UTC, Anju T Sudhakar wrote: > The data structure (i.e struct imc_mem_info) to hold the memory address > information for nest imc units is allocated based on the number of nodes > in the system. > > nest_imc_event_init() traverse this struct array to calculate the memory > base address for the event-cpu. If we fail to find a match for the event > cpu's chip-id in imc_mem_info struct array, then the do-while loop will > iterate until we crash. > > Fix this by changing the loop exit condition based on the number of > non zero vbase elements in the array, since the allocation is done for > nr_chips + 1. > > Reported-by: Dan Carpenter > Fixes: 885dcd709ba91 ( powerpc/perf: Add nest IMC PMU support) > Signed-off-by: Anju T Sudhakar > Reviewed-by: Madhavan Srinivasan Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/860b7d2286236170a36f94946d03ca98 cheers