linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc: config: skiroot: Add (back) MLX5 ethernet support
@ 2019-04-03  0:49 Joel Stanley
  2019-04-03  7:12 ` Mathieu Malaterre
  2019-05-03  6:59 ` Michael Ellerman
  0 siblings, 2 replies; 4+ messages in thread
From: Joel Stanley @ 2019-04-03  0:49 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Carol L Soto, Stewart Smith

It turns out that some defconfig changes and kernel config option
changes meant we accidentally dropped Ethernet support for Mellanox CLX5
cards.

Reported-by: Carol L Soto <clsoto@us.ibm.com>
Suggested-by: Carol L Soto <clsoto@us.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/powerpc/configs/skiroot_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/configs/skiroot_defconfig b/arch/powerpc/configs/skiroot_defconfig
index 5ba131c30f6b..6038b9347d9e 100644
--- a/arch/powerpc/configs/skiroot_defconfig
+++ b/arch/powerpc/configs/skiroot_defconfig
@@ -163,6 +163,8 @@ CONFIG_S2IO=m
 CONFIG_MLX4_EN=m
 # CONFIG_MLX4_CORE_GEN2 is not set
 CONFIG_MLX5_CORE=m
+CONFIG_MLX5_CORE_EN=y
+# CONFIG_MLX5_EN_RXNFC is not set
 # CONFIG_NET_VENDOR_MICREL is not set
 # CONFIG_NET_VENDOR_MICROSEMI is not set
 CONFIG_MYRI10GE=m
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] powerpc: config: skiroot: Add (back) MLX5 ethernet support
  2019-04-03  0:49 [PATCH] powerpc: config: skiroot: Add (back) MLX5 ethernet support Joel Stanley
@ 2019-04-03  7:12 ` Mathieu Malaterre
  2019-04-03 20:53   ` Stewart Smith
  2019-05-03  6:59 ` Michael Ellerman
  1 sibling, 1 reply; 4+ messages in thread
From: Mathieu Malaterre @ 2019-04-03  7:12 UTC (permalink / raw)
  To: Joel Stanley; +Cc: Carol L Soto, linuxppc-dev, Stewart Smith

On Wed, Apr 3, 2019 at 2:51 AM Joel Stanley <joel@jms.id.au> wrote:
>
> It turns out that some defconfig changes and kernel config option
> changes meant we accidentally dropped Ethernet support for Mellanox CLX5
> cards.
>
> Reported-by: Carol L Soto <clsoto@us.ibm.com>
> Suggested-by: Carol L Soto <clsoto@us.ibm.com>
> Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Fixes: cbc39809a398 ("powerpc/configs: Update skiroot defconfig")

?

> ---
>  arch/powerpc/configs/skiroot_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/configs/skiroot_defconfig b/arch/powerpc/configs/skiroot_defconfig
> index 5ba131c30f6b..6038b9347d9e 100644
> --- a/arch/powerpc/configs/skiroot_defconfig
> +++ b/arch/powerpc/configs/skiroot_defconfig
> @@ -163,6 +163,8 @@ CONFIG_S2IO=m
>  CONFIG_MLX4_EN=m
>  # CONFIG_MLX4_CORE_GEN2 is not set
>  CONFIG_MLX5_CORE=m
> +CONFIG_MLX5_CORE_EN=y
> +# CONFIG_MLX5_EN_RXNFC is not set
>  # CONFIG_NET_VENDOR_MICREL is not set
>  # CONFIG_NET_VENDOR_MICROSEMI is not set
>  CONFIG_MYRI10GE=m
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] powerpc: config: skiroot: Add (back) MLX5 ethernet support
  2019-04-03  7:12 ` Mathieu Malaterre
@ 2019-04-03 20:53   ` Stewart Smith
  0 siblings, 0 replies; 4+ messages in thread
From: Stewart Smith @ 2019-04-03 20:53 UTC (permalink / raw)
  To: Mathieu Malaterre, Joel Stanley; +Cc: Carol L Soto, linuxppc-dev

Mathieu Malaterre <malat@debian.org> writes:
> On Wed, Apr 3, 2019 at 2:51 AM Joel Stanley <joel@jms.id.au> wrote:
>>
>> It turns out that some defconfig changes and kernel config option
>> changes meant we accidentally dropped Ethernet support for Mellanox CLX5
>> cards.
>>
>> Reported-by: Carol L Soto <clsoto@us.ibm.com>
>> Suggested-by: Carol L Soto <clsoto@us.ibm.com>
>> Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>
> Fixes: cbc39809a398 ("powerpc/configs: Update skiroot defconfig")
>
> ?

Yes.

-- 
Stewart Smith
OPAL Architect, IBM.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] powerpc: config: skiroot: Add (back) MLX5 ethernet support
  2019-04-03  0:49 [PATCH] powerpc: config: skiroot: Add (back) MLX5 ethernet support Joel Stanley
  2019-04-03  7:12 ` Mathieu Malaterre
@ 2019-05-03  6:59 ` Michael Ellerman
  1 sibling, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2019-05-03  6:59 UTC (permalink / raw)
  To: Joel Stanley, linuxppc-dev; +Cc: Carol L Soto, Stewart Smith

On Wed, 2019-04-03 at 00:49:26 UTC, Joel Stanley wrote:
> It turns out that some defconfig changes and kernel config option
> changes meant we accidentally dropped Ethernet support for Mellanox CLX5
> cards.
> 
> Reported-by: Carol L Soto <clsoto@us.ibm.com>
> Suggested-by: Carol L Soto <clsoto@us.ibm.com>
> Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/e1619e89c96c596d72e66f15a0794f50

cheers

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-05-03  7:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-03  0:49 [PATCH] powerpc: config: skiroot: Add (back) MLX5 ethernet support Joel Stanley
2019-04-03  7:12 ` Mathieu Malaterre
2019-04-03 20:53   ` Stewart Smith
2019-05-03  6:59 ` Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).