From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C48C04A6B for ; Mon, 6 May 2019 13:58:23 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 605782054F for ; Mon, 6 May 2019 13:58:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 605782054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44yPTS6tyYzDqHj for ; Mon, 6 May 2019 23:58:20 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44yPNY3k2DzDqHh for ; Mon, 6 May 2019 23:54:05 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: by ozlabs.org (Postfix, from userid 1034) id 44yPNY0bjTz9s7T; Mon, 6 May 2019 23:54:05 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 6be6a8de1b55e719e3f95894910743719065d6a1 X-Patchwork-Hint: ignore In-Reply-To: <20190504070430.57008-1-weiyongjun1@huawei.com> To: Wei Yongjun , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Alastair D'Silva From: Michael Ellerman Subject: Re: [PATCH -next] ocxl: Fix return value check in afu_ioctl() Message-Id: <44yPNY0bjTz9s7T@ozlabs.org> Date: Mon, 6 May 2019 23:54:05 +1000 (AEST) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Wei Yongjun Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, 2019-05-04 at 07:04:30 UTC, Wei Yongjun wrote: > In case of error, the function eventfd_ctx_fdget() returns ERR_PTR() and > never returns NULL. The NULL test in the return value check should be > replaced with IS_ERR(). > > This issue was detected by using the Coccinelle software. > > Fixes: 060146614643 ("ocxl: move event_fd handling to frontend") > Signed-off-by: Wei Yongjun > Acked-by: Alastair D'Silva > Acked-by: Andrew Donnellan Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/6be6a8de1b55e719e3f9589491074371 cheers