* [PATCH] powerpc/mm: Fix hugetlb page initialization
@ 2019-05-06 12:03 Sachin Sant
2019-05-06 12:07 ` Christophe Leroy
2019-05-06 13:54 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Sant @ 2019-05-06 12:03 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Sachin Sant, Michael Ellerman
This patch fixes a regression by using correct kernel config variable
for HUGETLB_PAGE_SIZE_VARIABLE.
Without this huge pages are disabled during kernel boot.
[0.309496] hugetlbfs: disabling because there are no supported hugepage sizes
Fixes: c5710cd20735 ("powerpc/mm: cleanup HPAGE_SHIFT setup")
Reported-by: Sachin Sant <sachinp@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Tested-by: Sachin Sant <sachinp@linux.ibm.com>
---
diff -Narup a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
--- a/arch/powerpc/mm/hugetlbpage.c 2019-05-06 07:30:11.711092744 -0400
+++ b/arch/powerpc/mm/hugetlbpage.c 2019-05-06 07:29:32.963433258 -0400
@@ -640,7 +640,7 @@ static int __init hugetlbpage_init(void)
pgtable_cache_add(PTE_T_ORDER);
}
- if (IS_ENABLED(HUGETLB_PAGE_SIZE_VARIABLE))
+ if (IS_ENABLED(CONFIG_HUGETLB_PAGE_SIZE_VARIABLE))
hugetlbpage_init_default();
return 0;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/mm: Fix hugetlb page initialization
2019-05-06 12:03 [PATCH] powerpc/mm: Fix hugetlb page initialization Sachin Sant
@ 2019-05-06 12:07 ` Christophe Leroy
2019-05-06 13:54 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Leroy @ 2019-05-06 12:07 UTC (permalink / raw)
To: Sachin Sant, linuxppc-dev; +Cc: Michael Ellerman
Le 06/05/2019 à 14:03, Sachin Sant a écrit :
> This patch fixes a regression by using correct kernel config variable
> for HUGETLB_PAGE_SIZE_VARIABLE.
>
> Without this huge pages are disabled during kernel boot.
> [0.309496] hugetlbfs: disabling because there are no supported hugepage sizes
>
> Fixes: c5710cd20735 ("powerpc/mm: cleanup HPAGE_SHIFT setup")
> Reported-by: Sachin Sant <sachinp@linux.ibm.com>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Tested-by: Sachin Sant <sachinp@linux.ibm.com>
Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
>
> ---
> diff -Narup a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
> --- a/arch/powerpc/mm/hugetlbpage.c 2019-05-06 07:30:11.711092744 -0400
> +++ b/arch/powerpc/mm/hugetlbpage.c 2019-05-06 07:29:32.963433258 -0400
> @@ -640,7 +640,7 @@ static int __init hugetlbpage_init(void)
> pgtable_cache_add(PTE_T_ORDER);
> }
>
> - if (IS_ENABLED(HUGETLB_PAGE_SIZE_VARIABLE))
> + if (IS_ENABLED(CONFIG_HUGETLB_PAGE_SIZE_VARIABLE))
> hugetlbpage_init_default();
>
> return 0;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/mm: Fix hugetlb page initialization
2019-05-06 12:03 [PATCH] powerpc/mm: Fix hugetlb page initialization Sachin Sant
2019-05-06 12:07 ` Christophe Leroy
@ 2019-05-06 13:54 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2019-05-06 13:54 UTC (permalink / raw)
To: Sachin Sant, linuxppc-dev; +Cc: Sachin Sant, Michael Ellerman
On Mon, 2019-05-06 at 12:03:33 UTC, Sachin Sant wrote:
> This patch fixes a regression by using correct kernel config variable
> for HUGETLB_PAGE_SIZE_VARIABLE.
>
> Without this huge pages are disabled during kernel boot.
> [0.309496] hugetlbfs: disabling because there are no supported hugepage sizes
>
> Fixes: c5710cd20735 ("powerpc/mm: cleanup HPAGE_SHIFT setup")
> Reported-by: Sachin Sant <sachinp@linux.ibm.com>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Tested-by: Sachin Sant <sachinp@linux.ibm.com>
> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/04a1942933ced67d2b73c156017bf134
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-06 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-06 12:03 [PATCH] powerpc/mm: Fix hugetlb page initialization Sachin Sant
2019-05-06 12:07 ` Christophe Leroy
2019-05-06 13:54 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).