From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, linux1394-devel@lists.sourceforge.net,
Bernhard Kaindl <bk@fsfe.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [Fwd: Re: ohci1394: steps to implement suspend/resume]
Date: Thu, 07 Sep 2006 21:34:21 +0200 [thread overview]
Message-ID: <4500743D.9000403@s5r6.in-berlin.de> (raw)
In-Reply-To: <1157590416.22705.269.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Wed, 2006-09-06 at 16:46 +0200, Stefan Richter wrote:
[...]
>> We already broke your platform code once by what was meant as a bugfix
>> for non-PMacs. It'd be good to know enough to not repeat such mistakes...
>
> The PowerMac code will stop the chip clocks. It should be used as the
> last step of the suspend sequence and first step of the return sequence,
> in _addition_ to your new code.
Thanks for the help.
> Note also that the code you posted lacks calls to pci_set_power_state()...
Pavel submitted a respective patch on 2006-09-05; I will integrate them
both.
--
Stefan Richter
-=====-=-==- =--= --===
http://arcgraph.de/sr/
next prev parent reply other threads:[~2006-09-07 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-06 14:46 [Fwd: Re: ohci1394: steps to implement suspend/resume] Stefan Richter
2006-09-07 0:53 ` Benjamin Herrenschmidt
2006-09-07 19:34 ` Stefan Richter [this message]
2006-09-07 23:30 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4500743D.9000403@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=benh@kernel.crashing.org \
--cc=bk@fsfe.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).