* [PATCH 4/11] qe_lib: Add QE I/O ports API
@ 2006-09-21 12:18 Li Yang
0 siblings, 0 replies; 6+ messages in thread
From: Li Yang @ 2006-09-21 12:18 UTC (permalink / raw)
To: linuxppc-dev
Signed-off-by: Li Yang <leoli@freescale.com>
Signed-off-by: Shlomi Gridish <gridish@freescale.com>
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
arch/powerpc/sysdev/qe_lib/qe_io.c | 272 ++++++++++++++++++++++++++++++++++++
1 files changed, 272 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/sysdev/qe_lib/qe_io.c b/arch/powerpc/sysdev/qe_lib/qe_io.c
new file mode 100644
index 0000000..e905d35
--- /dev/null
+++ b/arch/powerpc/sysdev/qe_lib/qe_io.c
@@ -0,0 +1,272 @@
+/*
+ * Copyright (C) Freescale Semicondutor, Inc. 2006. All rights reserved.
+ *
+ * Author: Li Yang <LeoLi@freescale.com>
+ *
+ * Description:
+ * QE Parallel I/O ports configuration routines. Based on code from
+ * Shlomi Gridish <gridish@freescale.com>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ */
+
+#include <linux/config.h>
+#include <linux/stddef.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/errno.h>
+#include <linux/module.h>
+
+#include <asm/io.h>
+#include <asm/prom.h>
+#include <sysdev/fsl_soc.h>
+#undef DEBUG
+
+#define NUM_OF_PINS 32
+#define NUM_OF_PAR_IOS 7
+
+typedef struct par_io {
+ struct {
+ u32 cpodr; /* Open drain register */
+ u32 cpdata; /* Data register */
+ u32 cpdir1; /* Direction register */
+ u32 cpdir2; /* Direction register */
+ u32 cppar1; /* Pin assignment register */
+ u32 cppar2; /* Pin assignment register */
+ } io_regs[NUM_OF_PAR_IOS];
+} par_io_t;
+
+typedef struct qe_par_io {
+ u8 res[0xc];
+ u32 cepier; /* QE ports interrupt event register */
+ u32 cepimr; /* QE ports mask event register */
+ u32 cepicr; /* QE ports control event register */
+} qe_par_io_t;
+
+static int qe_irq_ports[NUM_OF_PAR_IOS][NUM_OF_PINS] = {
+ /* 0-7 */ /* 8-15 */ /* 16 - 23 */ /* 24 - 31 */
+ {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,1, 1,0,0,0,0,0,0,0, 0,0,0,0,0,1,1,0},
+ {0,0,0,1,0,1,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0, 0,0,1,1,0,0,0,0},
+ {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,1,1,1,0,0},
+ {0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 1,1,0,0,0,0,0,0, 0,0,1,1,0,0,0,0},
+ {0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0, 1,1,1,1,0,0,0,1},
+ {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,1,0,0,0, 0,0,0,0,0,0,0,0},
+ {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,1}
+};
+
+
+static u8 get_irq_num(u8 port, u8 pin)
+{
+ int i, j;
+ u8 num = 0;
+
+ if (qe_irq_ports[port][pin] == 0)
+ return -1;
+ for (j = 0; j <= port; j++)
+ for (i = 0; i < pin; i++)
+ if (qe_irq_ports[j][i])
+ num++;
+ return num;
+}
+
+static par_io_t *par_io = NULL;
+static qe_par_io_t *qe_par_io = NULL;
+
+int par_io_config_pin(u8 port, u8 pin, int dir, int open_drain,
+ int assignment, int has_irq)
+{
+ u32 pinMask1bit, pinMask2bits, newMask2bits, tmp_val;
+
+ if (!par_io) {
+ par_io = (par_io_t *) ioremap(get_immrbase() + 0x1400,
+ sizeof(par_io_t));
+ qe_par_io = (qe_par_io_t *) ioremap(get_immrbase() + 0xC00,
+ sizeof(qe_par_io_t));
+
+ /* clear event bits in the event register of the QE ports */
+ out_be32(&qe_par_io->cepier, 0xFFFFFFFF);
+ }
+
+ /* calculate pin location for single and 2 bits information */
+ pinMask1bit = (u32) (1 << (NUM_OF_PINS - (pin + 1)));
+
+ /* Set open drain, if required */
+ tmp_val = in_be32(&par_io->io_regs[port].cpodr);
+ if (open_drain)
+ out_be32(&par_io->io_regs[port].cpodr, pinMask1bit | tmp_val);
+ else
+ out_be32(&par_io->io_regs[port].cpodr, ~pinMask1bit & tmp_val);
+
+ /* define direction */
+ tmp_val = (pin > (NUM_OF_PINS / 2) - 1) ?
+ in_be32(&par_io->io_regs[port].cpdir2) :
+ in_be32(&par_io->io_regs[port].cpdir1);
+
+ /* get all bits mask for 2 bit per port */
+ pinMask2bits = (u32) (0x3 <<
+ (NUM_OF_PINS -
+ (pin % (NUM_OF_PINS / 2) + 1) * 2));
+
+ /* Get the final mask we need for the right definition */
+ newMask2bits = (u32) (dir <<
+ (NUM_OF_PINS -
+ (pin % (NUM_OF_PINS / 2) + 1) * 2));
+
+ /* clear and set 2 bits mask */
+ if (pin > (NUM_OF_PINS / 2) - 1) {
+ out_be32(&par_io->io_regs[port].cpdir2,
+ ~pinMask2bits & tmp_val);
+ tmp_val &= ~pinMask2bits;
+ out_be32(&par_io->io_regs[port].cpdir2, newMask2bits | tmp_val);
+ } else {
+ out_be32(&par_io->io_regs[port].cpdir1,
+ ~pinMask2bits & tmp_val);
+ tmp_val &= ~pinMask2bits;
+ out_be32(&par_io->io_regs[port].cpdir1, newMask2bits | tmp_val);
+ }
+ /* define pin assignment */
+ tmp_val = (pin > (NUM_OF_PINS / 2) - 1) ?
+ in_be32(&par_io->io_regs[port].cppar2) :
+ in_be32(&par_io->io_regs[port].cppar1);
+
+ newMask2bits = (u32) (assignment << (NUM_OF_PINS -
+ (pin % (NUM_OF_PINS / 2) + 1) * 2));
+ /* clear and set 2 bits mask */
+ if (pin > (NUM_OF_PINS / 2) - 1) {
+ out_be32(&par_io->io_regs[port].cppar2,
+ ~pinMask2bits & tmp_val);
+ tmp_val &= ~pinMask2bits;
+ out_be32(&par_io->io_regs[port].cppar2, newMask2bits | tmp_val);
+ } else {
+ out_be32(&par_io->io_regs[port].cppar1,
+ ~pinMask2bits & tmp_val);
+ tmp_val &= ~pinMask2bits;
+ out_be32(&par_io->io_regs[port].cppar1, newMask2bits | tmp_val);
+ }
+
+ /* Set interrupt mask if the pin generates interrupt */
+ if (has_irq) {
+ int irq = get_irq_num(port, pin);
+ u32 mask = 0;
+
+ if (irq == -1) {
+ printk(KERN_WARNING "Port %d, pin %d is can't be "
+ "interrupt\n", port, pin);
+ return -EINVAL;
+ }
+ mask = 0x80000000 >> irq;
+
+ tmp_val = in_be32(&qe_par_io->cepimr);
+ out_be32(&qe_par_io->cepimr, mask | tmp_val);
+ }
+
+ return 0;
+}
+
+EXPORT_SYMBOL(par_io_config_pin);
+
+int par_io_data_set(u8 port, u8 pin, u8 val)
+{
+ u32 pin_mask, tmp_val;
+
+ if (port >= NUM_OF_PAR_IOS)
+ return -EINVAL;
+ if (pin >= NUM_OF_PINS)
+ return -EINVAL;
+ /* calculate pin location */
+ pin_mask = (u32) (1 << (NUM_OF_PINS - 1 - pin));
+
+ tmp_val = in_be32(&par_io->io_regs[port].cpdata);
+
+ if (val == 0) /* clear */
+ out_be32(&par_io->io_regs[port].cpdata, ~pin_mask & tmp_val);
+ else /* set */
+ out_be32(&par_io->io_regs[port].cpdata, pin_mask | tmp_val);
+
+ return 0;
+}
+
+EXPORT_SYMBOL(par_io_data_set);
+
+int par_io_of_config(struct device_node *np)
+{
+ struct device_node *pio;
+ phandle *ph;
+ int pio_map_len;
+ unsigned int *pio_map;
+
+ ph = (phandle *) get_property(np, "pio-handle", NULL);
+ if (ph == 0) {
+ printk(KERN_ERR "pio-handle not available \n");
+ return -1;
+ }
+
+ pio = of_find_node_by_phandle(*ph);
+
+ pio_map = (unsigned int *)
+ get_property(pio, "pio-map", &pio_map_len);
+ if (pio_map == NULL) {
+ printk(KERN_ERR "pio-map is not set! \n");
+ return -1;
+ }
+ pio_map_len /= sizeof(unsigned int);
+ if ((pio_map_len % 6) != 0) {
+ printk(KERN_ERR "pio-map format wrong! \n");
+ return -1;
+ }
+
+ while (pio_map_len > 0) {
+ par_io_config_pin((u8) pio_map[0], (u8) pio_map[1],
+ (int) pio_map[2], (int) pio_map[3],
+ (int) pio_map[4], (int) pio_map[5]);
+ pio_map += 6;
+ pio_map_len -= 6;
+ }
+ of_node_put(pio);
+ return 0;
+}
+EXPORT_SYMBOL(par_io_of_config);
+
+#ifdef DEBUG
+static void dump_par_io(void)
+{
+ int i;
+
+ printk(KERN_INFO "PAR IO registars:\n");
+ printk(KERN_INFO "Base address: 0x%08x\n", (u32) par_io);
+ for (i = 0; i < NUM_OF_PAR_IOS; i++) {
+ printk(KERN_INFO "cpodr[%d] : addr - 0x%08x, val - 0x%08x\n",
+ i, (u32) & par_io->io_regs[i].cpodr,
+ in_be32(&par_io->io_regs[i].cpodr));
+ printk(KERN_INFO "cpdata[%d]: addr - 0x%08x, val - 0x%08x\n",
+ i, (u32) & par_io->io_regs[i].cpdata,
+ in_be32(&par_io->io_regs[i].cpdata));
+ printk(KERN_INFO "cpdir1[%d]: addr - 0x%08x, val - 0x%08x\n",
+ i, (u32) & par_io->io_regs[i].cpdir1,
+ in_be32(&par_io->io_regs[i].cpdir1));
+ printk(KERN_INFO "cpdir2[%d]: addr - 0x%08x, val - 0x%08x\n",
+ i, (u32) & par_io->io_regs[i].cpdir2,
+ in_be32(&par_io->io_regs[i].cpdir2));
+ printk(KERN_INFO "cppar1[%d]: addr - 0x%08x, val - 0x%08x\n",
+ i, (u32) & par_io->io_regs[i].cppar1,
+ in_be32(&par_io->io_regs[i].cppar1));
+ printk(KERN_INFO "cppar2[%d]: addr - 0x%08x, val - 0x%08x\n",
+ i, (u32) & par_io->io_regs[i].cppar2,
+ in_be32(&par_io->io_regs[i].cppar2));
+ }
+
+ printk(KERN_INFO "QE PAR IO registars:\n");
+ printk(KERN_INFO "Base address: 0x%08x\n", (u32) qe_par_io);
+ printk(KERN_INFO "cepier : addr - 0x%08x, val - 0x%08x\n",
+ (u32) & qe_par_io->cepier, in_be32(&qe_par_io->cepier));
+ printk(KERN_INFO "cepimr : addr - 0x%08x, val - 0x%08x\n",
+ (u32) & qe_par_io->cepimr, in_be32(&qe_par_io->cepimr));
+ printk(KERN_INFO "cepicr : addr - 0x%08x, val - 0x%08x\n",
+ (u32) & qe_par_io->cepicr, in_be32(&qe_par_io->cepicr));
+}
+
+EXPORT_SYMBOL(dump_par_io);
+#endif
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH 4/11] qe_lib: Add QE I/O ports API
@ 2006-09-21 14:52 Joakim Tjernlund
2006-09-21 15:21 ` Vitaly Bordug
2006-09-21 20:38 ` Andy Fleming
0 siblings, 2 replies; 6+ messages in thread
From: Joakim Tjernlund @ 2006-09-21 14:52 UTC (permalink / raw)
To: Li Yang, linuxppc-dev
Hi Leo
As you know I working with your earlier patches, trying to adopt them
for
8321. Everthing works but ethernet on UCC2 and UCC4, ethernet on UCC3
works though.
Anyhow I found some minor changes I had to do to match 8321 that is
generic 83xx code.
Below is the first:
> ---
> arch/powerpc/sysdev/qe_lib/qe_io.c | 272=20
> +#define NUM_OF_PAR_IOS 7
NUM_OF_PAR_IOS is 4 on 8321
> +static int qe_irq_ports[NUM_OF_PAR_IOS][NUM_OF_PINS] =3D {
> + /* 0-7 */ /* 8-15 */ /* 16 - 23 */ /*=20
> 24 - 31 */
> + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,1, 1,0,0,0,0,0,0,0,=20
> 0,0,0,0,0,1,1,0},
> + {0,0,0,1,0,1,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,=20
> 0,0,1,1,0,0,0,0},
> + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,=20
> 0,0,0,1,1,1,0,0},
> + {0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 1,1,0,0,0,0,0,0,=20
> 0,0,1,1,0,0,0,0},
> + {0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,=20
> 1,1,1,1,0,0,0,1},
> + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,1,0,0,0,=20
> 0,0,0,0,0,0,0,0},
> + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,=20
> 0,0,0,0,0,0,0,1}
> +};
qe_irq_ports is diffrent on 8321 not only the number of rows.
These needs to configuruable based on CPU model and/or type of board.
Jocke
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/11] qe_lib: Add QE I/O ports API
2006-09-21 14:52 Joakim Tjernlund
@ 2006-09-21 15:21 ` Vitaly Bordug
2006-09-21 23:22 ` Benjamin Herrenschmidt
2006-09-22 6:29 ` Li Yang-r58472
2006-09-21 20:38 ` Andy Fleming
1 sibling, 2 replies; 6+ messages in thread
From: Vitaly Bordug @ 2006-09-21 15:21 UTC (permalink / raw)
To: Joakim Tjernlund; +Cc: linuxppc-dev, Li Yang
On Thu, 21 Sep 2006 16:52:14 +0200
"Joakim Tjernlund" <joakim.tjernlund@transmode.se> wrote:
> Hi Leo
>
> As you know I working with your earlier patches, trying to adopt them
> for
> 8321. Everthing works but ethernet on UCC2 and UCC4, ethernet on UCC3
> works though.
>
> Anyhow I found some minor changes I had to do to match 8321 that is
> generic 83xx code.
> Below is the first:
> > ---
> > arch/powerpc/sysdev/qe_lib/qe_io.c | 272
> > +#define NUM_OF_PAR_IOS 7
>
> NUM_OF_PAR_IOS is 4 on 8321
>
> > +static int qe_irq_ports[NUM_OF_PAR_IOS][NUM_OF_PINS] = {
> > + /* 0-7 */ /* 8-15 */ /* 16 - 23 */ /*
> > 24 - 31 */
> > + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,1, 1,0,0,0,0,0,0,0,
> > 0,0,0,0,0,1,1,0},
> > + {0,0,0,1,0,1,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,
> > 0,0,1,1,0,0,0,0},
> > + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,
> > 0,0,0,1,1,1,0,0},
> > + {0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 1,1,0,0,0,0,0,0,
> > 0,0,1,1,0,0,0,0},
> > + {0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,
> > 1,1,1,1,0,0,0,1},
> > + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,1,0,0,0,
> > 0,0,0,0,0,0,0,0},
> > + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,
> > 0,0,0,0,0,0,0,1}
> > +};
>
> qe_irq_ports is diffrent on 8321 not only the number of rows.
>
> These needs to configuruable based on CPU model and/or type of board.
>
Well, eventually this stuff aims to serve not 83xx/qe, but for cpm(1,2)-equipped stuff
too. Apparently, we'll have to do something wise to afford that...
OTOH, this is good as a starting point I guess.
--
Sincerely,
Vitaly
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/11] qe_lib: Add QE I/O ports API
2006-09-21 14:52 Joakim Tjernlund
2006-09-21 15:21 ` Vitaly Bordug
@ 2006-09-21 20:38 ` Andy Fleming
1 sibling, 0 replies; 6+ messages in thread
From: Andy Fleming @ 2006-09-21 20:38 UTC (permalink / raw)
To: Joakim Tjernlund; +Cc: linuxppc-dev, Li Yang
>
>> +static int qe_irq_ports[NUM_OF_PAR_IOS][NUM_OF_PINS] = {
>> + /* 0-7 */ /* 8-15 */ /* 16 - 23 */ /*
>> 24 - 31 */
>> + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,1, 1,0,0,0,0,0,0,0,
>> 0,0,0,0,0,1,1,0},
>> + {0,0,0,1,0,1,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,
>> 0,0,1,1,0,0,0,0},
>> + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,
>> 0,0,0,1,1,1,0,0},
>> + {0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 1,1,0,0,0,0,0,0,
>> 0,0,1,1,0,0,0,0},
>> + {0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,
>> 1,1,1,1,0,0,0,1},
>> + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,1,0,0,0,
>> 0,0,0,0,0,0,0,0},
>> + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,
>> 0,0,0,0,0,0,0,1}
>> +};
>
> qe_irq_ports is diffrent on 8321 not only the number of rows.
>
> These needs to configuruable based on CPU model and/or type of board.
That sounds like a job for the DTS
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/11] qe_lib: Add QE I/O ports API
2006-09-21 15:21 ` Vitaly Bordug
@ 2006-09-21 23:22 ` Benjamin Herrenschmidt
2006-09-22 6:29 ` Li Yang-r58472
1 sibling, 0 replies; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2006-09-21 23:22 UTC (permalink / raw)
To: Vitaly Bordug; +Cc: linuxppc-dev, Li Yang
> Well, eventually this stuff aims to serve not 83xx/qe, but for cpm(1,2)-equipped stuff
> too. Apparently, we'll have to do something wise to afford that...
>
> OTOH, this is good as a starting point I guess.
This is typical of stuff that should be in the device-tree
Ben.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 4/11] qe_lib: Add QE I/O ports API
2006-09-21 15:21 ` Vitaly Bordug
2006-09-21 23:22 ` Benjamin Herrenschmidt
@ 2006-09-22 6:29 ` Li Yang-r58472
1 sibling, 0 replies; 6+ messages in thread
From: Li Yang-r58472 @ 2006-09-22 6:29 UTC (permalink / raw)
To: Vitaly Bordug, Joakim Tjernlund; +Cc: linuxppc-dev
> -----Original Message-----
> From: Vitaly Bordug [mailto:vbordug@ru.mvista.com]
> Sent: Thursday, September 21, 2006 11:22 PM
> To: Joakim Tjernlund
> Cc: Li Yang-r58472; linuxppc-dev@ozlabs.org
> Subject: Re: [PATCH 4/11] qe_lib: Add QE I/O ports API
>=20
> On Thu, 21 Sep 2006 16:52:14 +0200
> "Joakim Tjernlund" <joakim.tjernlund@transmode.se> wrote:
>=20
> > Hi Leo
> >
> > As you know I working with your earlier patches, trying to adopt
them
> > for
> > 8321. Everthing works but ethernet on UCC2 and UCC4, ethernet on
UCC3
> > works though.
> >
> > Anyhow I found some minor changes I had to do to match 8321 that is
> > generic 83xx code.
> > Below is the first:
> > > ---
> > > arch/powerpc/sysdev/qe_lib/qe_io.c | 272
> > > +#define NUM_OF_PAR_IOS 7
> >
> > NUM_OF_PAR_IOS is 4 on 8321
> >
> > > +static int qe_irq_ports[NUM_OF_PAR_IOS][NUM_OF_PINS] =3D {
> > > + /* 0-7 */ /* 8-15 */ /* 16 - 23 */ /*
> > > 24 - 31 */
> > > + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,1, 1,0,0,0,0,0,0,0,
> > > 0,0,0,0,0,1,1,0},
> > > + {0,0,0,1,0,1,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,
> > > 0,0,1,1,0,0,0,0},
> > > + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,
> > > 0,0,0,1,1,1,0,0},
> > > + {0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 1,1,0,0,0,0,0,0,
> > > 0,0,1,1,0,0,0,0},
> > > + {0,0,0,0,0,0,0,0, 0,0,0,0,1,1,0,0, 0,0,0,0,0,0,0,0,
> > > 1,1,1,1,0,0,0,1},
> > > + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,1,0,0,0,
> > > 0,0,0,0,0,0,0,0},
> > > + {0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,
> > > 0,0,0,0,0,0,0,1}
> > > +};
> >
> > qe_irq_ports is diffrent on 8321 not only the number of rows.
> >
> > These needs to configuruable based on CPU model and/or type of
board.
> >
>=20
> Well, eventually this stuff aims to serve not 83xx/qe, but for
cpm(1,2)-equipped
> stuff
> too. Apparently, we'll have to do something wise to afford that...
>=20
> OTOH, this is good as a starting point I guess.
I agree. I will remove the I/O port interrupt stuff for now. Anyway,
it is not used by any code in kernel for now.
- Leo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-09-22 6:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-21 12:18 [PATCH 4/11] qe_lib: Add QE I/O ports API Li Yang
-- strict thread matches above, loose matches on Subject: below --
2006-09-21 14:52 Joakim Tjernlund
2006-09-21 15:21 ` Vitaly Bordug
2006-09-21 23:22 ` Benjamin Herrenschmidt
2006-09-22 6:29 ` Li Yang-r58472
2006-09-21 20:38 ` Andy Fleming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).