From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10A91CCFA04 for ; Tue, 4 Nov 2025 16:53:38 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4d1F012pNYz3bfM; Wed, 5 Nov 2025 03:53:37 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=192.198.163.14 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1762275217; cv=none; b=VLf767cgDo9744iBn/qCeQN2PFPw60SVm5hDWAqGrFtYnL942QMkBVSg4cW999yeB7oHzwc00gkMLdZl0a+sXT62TJ/VfsQisfT5ZVTbCdVvFBFyyaMP8PVwQJnSMzVelKLVFOp6Zawh8GXgPGhngEpc/fSPEjgkT+zOjX6+WaFT5N1FbGHFFKQk8COg4SWV3cRV28nyXX60ODdvWyaWOiDXBQmHaqLF7ML7vGZjqunTVkxsMy3skqdyh2lxZqIVMzHc4DyFAbcw5OvribLYx8MnxZDO5Gh+YAedVo11joj6XBFNPeYMhFiAiS8t15nf1LBS0L/uIWYL8OfQas3xJA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1762275217; c=relaxed/relaxed; bh=K27NOgtb5k1iecQxNTWvLkZwmXT8q9mNmJD7bsk212A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ohDes+yXUF5UnaE6FTZxrk4zm2qMp3/SNnFbt+voGEmJaqPhcLJplO3irl0BRzZbpeqsdrNS9eJR05uOpsshfMsFkynvJOwdzeB+mo4hnKxYs6irdww9UD4KL3pytQyO5rB6IdTOeQ0QcyWJb9W4HJYbGseK8Nq3DSHmRwwJIo3Gxv7fxMeMUQ/1Dn7CPHJBxc/8MwEFl0NafmYIiQLUZmen/tmQorJaIRMf6EVvt5MESLjJCbhi245v2JzvGu1XyDICvIVvxH1zwEdQaPmZ1aVU40C8VGrayOKMrAGRXJowZnKBYWnUpGCqA21cFIhEhlr30Po3d20Ds6h2T3WbVw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=aIgyqREG; dkim-atps=neutral; spf=pass (client-ip=192.198.163.14; helo=mgamail.intel.com; envelope-from=fabio.m.de.francesco@linux.intel.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=aIgyqREG; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.intel.com (client-ip=192.198.163.14; helo=mgamail.intel.com; envelope-from=fabio.m.de.francesco@linux.intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4d1Dzy2Mpsz3bf8 for ; Wed, 5 Nov 2025 03:53:32 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1762275215; x=1793811215; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0Vi8CmVpksI68INMwO9Cwr5Wqs6m/qtWAkyblVIpvsA=; b=aIgyqREG+yn5jInPozYh9vLBKe52xZaWgoSPklsX0zpAW85PQdhDnLjS J/SjvlaxZbCAu9/HO49HZSeNbq3MLk5LDavuXfNJ4afJ2dxVoY+spnmwO 9qFAOs7hT0J0Wm5lXjmFFzhTSQ97ineRWGD68wsqPLyKdneHd83cZo5UK 9ujqV39hHb3eHa0Vc9vG4Jf+R/Ng3ZgQehT0AujZvwY1LrF3ZpjpaIyeQ Zu0AZXRKo9MR3U3zeZF9W7E91xG9jDEQrA/lw7V428/4cPnjsXtV16e1C yw8r5FwXf1ZvhYosnG31NRoN73oyFWHijbJWaeYotlIX5jQdlu9RGmkP0 A==; X-CSE-ConnectionGUID: 8H987ak5RZ6A9MVnohp1aQ== X-CSE-MsgGUID: YmrT2+VKQImTY9yNOX+0UQ== X-IronPort-AV: E=McAfee;i="6800,10657,11603"; a="64407548" X-IronPort-AV: E=Sophos;i="6.19,279,1754982000"; d="scan'208";a="64407548" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2025 08:53:30 -0800 X-CSE-ConnectionGUID: MacTnz2bToWrXxp7w5uRHw== X-CSE-MsgGUID: SWyiQwSoSH2xTfhg7s/xyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,279,1754982000"; d="scan'208";a="187057481" Received: from fdefranc-mobl3.ger.corp.intel.com (HELO fdefranc-mobl3.localnet) ([10.245.246.211]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2025 08:53:20 -0800 From: "Fabio M. De Francesco" To: Jonathan Cameron Cc: linux-cxl@vger.kernel.org, "Rafael J . Wysocki" , Len Brown , Tony Luck , Borislav Petkov , Hanjun Guo , Mauro Carvalho Chehab , Shuai Xue , Davidlohr Bueso , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , Sunil V L , Xiaofei Tan , Mario Limonciello , Huacai Chen , Heinrich Schuchardt , Arnd Bergmann , Peter Zijlstra , Ingo Molnar , Guo Weikang , Xin Li , Will Deacon , Huang Yiwei , Gavin Shan , Smita Koralahalli , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Li Ming , Ilpo =?UTF-8?B?SsOkcnZpbmVu?= , Kuppuswamy Sathyanarayanan , Karolina Stolarek , Jon Pan-Doh , Lukas Wunner , Shiju Jose , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 6/6 v6] ACPI: extlog: Trace CPER CXL Protocol Error Section Date: Tue, 04 Nov 2025 17:53:18 +0100 Message-ID: <4532273.UPlyArG6xL@fdefranc-mobl3> In-Reply-To: <20251028150609.000023bf@huawei.com> References: <20251023122612.1326748-1-fabio.m.de.francesco@linux.intel.com> <20251023122612.1326748-7-fabio.m.de.francesco@linux.intel.com> <20251028150609.000023bf@huawei.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Tuesday, October 28, 2025 4:06:09=E2=80=AFPM Central European Standard T= ime Jonathan Cameron wrote: > On Thu, 23 Oct 2025 14:25:41 +0200 > "Fabio M. De Francesco" wrote: >=20 > > When Firmware First is enabled, BIOS handles errors first and then it m= akes > > them available to the kernel via the Common Platform Error Record (CPER) > > sections (UEFI 2.10 Appendix N). Linux parses the CPER sections via one= of > > two similar paths, either ELOG or GHES. The errors managed by ELOG are > > signaled to the BIOS by the I/O Machine Check Architecture (I/O MCA). > >=20 > > Currently, ELOG and GHES show some inconsistencies in how they report to > > userspace via trace events. > >=20 > > Therefore, make the two mentioned paths act similarly by tracing the CP= ER > > CXL Protocol Error Section (UEFI v2.10, Appendix N.2.13). > >=20 > > Cc: Dan Williams > > Reviewed-by: Kuppuswamy Sathyanarayanan > > Signed-off-by: Fabio M. De Francesco >=20 > Just one small question. With that addressed,=20 > Reviewed-by: Jonathan Cameron >=20 > > diff --git a/drivers/cxl/core/ras.c b/drivers/cxl/core/ras.c > > index 2731ba3a0799..3f527b0c6509 100644 > > --- a/drivers/cxl/core/ras.c > > +++ b/drivers/cxl/core/ras.c > > @@ -105,6 +105,12 @@ static void cxl_cper_handle_prot_err(struct cxl_cp= er_prot_err_work_data *data) > > cxl_cper_trace_uncorr_prot_err(cxlmd, data->ras_cap); > > } > > =20 > > +void cxl_cper_ras_handle_prot_err(struct cxl_cper_prot_err_work_data *= wd) >=20 > Why do we need this wrapper? The name is a bit more general, so if you > do need it, then why not instead just rename cxl_cper_handle_prot_err() >=20 Actually, on a second thought I believe that we don't need either this wrapper or renaming cxl_cper_handle_prot_err(). I'll export the latter as it is. =46abio > > +{ > > + cxl_cper_handle_prot_err(wd); > > +} > > +EXPORT_SYMBOL_GPL(cxl_cper_ras_handle_prot_err); > > + > > static void cxl_cper_prot_err_work_fn(struct work_struct *work) > > { > > struct cxl_cper_prot_err_work_data wd; > > diff --git a/include/cxl/event.h b/include/cxl/event.h > > index 94081aec597a..a37eef112411 100644 > > --- a/include/cxl/event.h > > +++ b/include/cxl/event.h > > @@ -340,4 +340,6 @@ cxl_cper_setup_prot_err_work_data(struct cxl_cper_p= rot_err_work_data *wd, > > } > > #endif > > =20 > > +void cxl_cper_ras_handle_prot_err(struct cxl_cper_prot_err_work_data *= wd); > > + > > #endif /* _LINUX_CXL_EVENT_H */ >=20 >=20