From: "Randy.Dunlap" <randy.dunlap@oracle.com>
To: michael@ellerman.id.au
Cc: ppcdev <linuxppc-dev@ozlabs.org>, paulus <paulus@samba.org>
Subject: Re: [PATCH 1/2] ramdisk: make powerpc allmodconfig build
Date: Tue, 17 Oct 2006 21:56:42 -0700 [thread overview]
Message-ID: <4535B40A.80401@oracle.com> (raw)
In-Reply-To: <1161141055.7906.0.camel@localhost.localdomain>
Michael Ellerman wrote:
> On Tue, 2006-10-17 at 11:04 -0700, Judith Lebzelter wrote:
>> Hi Randy,
>>
>> There is another section in that function which depends on
>> 'CONFIG_BLK_DEV_INITRD' being defined. Although it does not throw an
>> error, it does depend on some of the variables set in this section,
>> but not 'rd_size'. I think for consistancy it might be better to do
>> somthing like this(below)? Or else add the same ifdef down there...
>>
>> Judith
>>
>>
>> Index: 2/linux/arch/powerpc/platforms/iseries/setup.c
>> ===================================================================
>> --- 2.orig/linux/arch/powerpc/platforms/iseries/setup.c 2006-10-17 10:49:31.423551104 -0700
>> +++ 2/linux/arch/powerpc/platforms/iseries/setup.c 2006-10-17 10:52:22.682515784 -0700
>> @@ -305,8 +305,10 @@
>> initrd_end = initrd_start + naca.xRamDiskSize * HW_PAGE_SIZE;
>> initrd_below_start_ok = 1; // ramdisk in kernel space
>> ROOT_DEV = Root_RAM0;
>> +#if defined(CONFIG_BLK_DEV_RAM)
>> if (((rd_size * 1024) / HW_PAGE_SIZE) < naca.xRamDiskSize)
>> rd_size = (naca.xRamDiskSize * HW_PAGE_SIZE) / 1024;
>> +#endif /* CONFIG_BLK_DEV_RAM */
>> } else
>> #endif /* CONFIG_BLK_DEV_INITRD */
>> {
>
> That code is bogus, we'll remove it entirely.
Great, thanks. :)
--
~Randy
prev parent reply other threads:[~2006-10-18 4:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 16:47 [PATCH 1/2] ramdisk: make powerpc allmodconfig build Randy Dunlap
2006-10-17 18:04 ` Judith Lebzelter
2006-10-17 20:29 ` Randy.Dunlap
2006-10-17 20:37 ` Randy.Dunlap
2006-10-18 3:10 ` Michael Ellerman
2006-10-18 4:56 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4535B40A.80401@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).