From: Santiago Leon <santil@us.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
David Gibson <david@gibson.dropbear.id.au>,
Paul Mackerras <paulus@samba.org>
Subject: Re: ibmveth and LIOBN field
Date: Wed, 18 Oct 2006 11:14:10 -0500 [thread overview]
Message-ID: <453652D2.8070609@us.ibm.com> (raw)
In-Reply-To: <1161150069.23947.18.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> Hi Santiago !
>
> I'm a bit annoyed by a bit of code in the ibmveth driver:
>
> It accesses the iommu table pointer, to get the index and put it into
> it's own private adapter->liobn member. However, that is never used
> anywhere except in ibmveth_seq_show() for the /proc stuff to display
> th'is LIOBN value.
>
> Is this actually useful ? I'd like to just remove that code.
I'll gladly sign off a patch that removes that code. I think we used
liobn in the driver a long time ago to do the tce mappings before we
merged all the common virtual io code into arch/powerpc/vio.c.
--
Santiago A. Leon
Power Linux Development
IBM Linux Technology Center
prev parent reply other threads:[~2006-10-18 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 5:41 ibmveth and LIOBN field Benjamin Herrenschmidt
2006-10-18 16:14 ` Santiago Leon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453652D2.8070609@us.ibm.com \
--to=santil@us.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).