From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from einhorn.in-berlin.de (einhorn.in-berlin.de [192.109.42.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail.vr.in-berlin.de", Issuer "IN-Berlin Server CA (G2)" (not verified)) by ozlabs.org (Postfix) with ESMTP id 6C0CF679E9 for ; Tue, 24 Oct 2006 21:42:28 +1000 (EST) Message-ID: <453DFBFF.8040001@s5r6.in-berlin.de> Date: Tue, 24 Oct 2006 13:41:51 +0200 From: Stefan Richter MIME-Version: 1.0 To: Benjamin Herrenschmidt Subject: Re: pci_set_power_state() failure and breaking suspend References: <1161672898.10524.596.camel@localhost.localdomain> <1161675611.10524.598.camel@localhost.localdomain> <453DCB17.6050304@s5r6.in-berlin.de> <1161678557.10524.602.camel@localhost.localdomain> In-Reply-To: <1161678557.10524.602.camel@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev list , linux1394-devel@lists.sourceforge.net, Linux Kernel list , Greg KH List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Benjamin Herrenschmidt wrote: > Well, the question is wether we want to make the whole machine suspend > fail because there is a 1394 chip that doesn't do PCI PM in or not... > > I can send patches "fixing" it both ways (just ignoring the result from > pci_set_power_state in general, or just ignoring that result on Apple > cells). Yes, what would be the correct way to do this? And if it the latter option, should that be implemented in ohci1394 or in pci_set_power_state? grep says that almost nobody checks the return code of pci_set_power_state. But e.g. usb/core/hcd-pci.c does... (Side note: The sole function that ohci1394's suspend and resume hooks fulfill right now in mainline is to change power consumption of the chip. The IEEE 1394 stack as a whole does not survive suspend + resume yet. A still incomplete solution is in linux1394-2.6.git.) -- Stefan Richter -=====-=-==- =-=- ==--- http://arcgraph.de/sr/