From: Sylvain Munaut <tnt@246tNt.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: ML PPC Embedded <linuxppc-embedded@ozlabs.org>, Sven <sl@bplan-gmbh.de>
Subject: Re: [PATCH] ppc/powerpc: Fix io.h for config with CONFIG_PCI not set
Date: Sun, 05 Nov 2006 02:45:15 +0100 [thread overview]
Message-ID: <454D422B.8030003@246tNt.com> (raw)
In-Reply-To: <1162689134.28571.120.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Sun, 2006-11-05 at 01:17 +0100, Sylvain Munaut wrote:
>
>> When CONFIG_PCI option is not set, the variables
>> pci_dram_offset, isa_io_base and isa_mem_base are not defined.
>>
>> Currently, the test is handled in each platform header. This
>> patch moves the test in io.h once and for all.
>>
>
> Be careful with _IO_BASE... I'm not 100% sure some platforms don't need
> it set to something else even when PCI is not present.
>
When I saw in mpc83xx.h and mpc85xx.h that they still defined them, I
wondered.
But when looking at the code :
unsigned long isa_io_base = 0;
unsigned long isa_mem_base = 0;
are both defined in pci_{32/64}.c and won't be included if CONFIG_PCI is
not set.
Sylvain
next prev parent reply other threads:[~2006-11-05 1:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-05 0:17 [PATCH] ppc/powerpc: Fix io.h for config with CONFIG_PCI not set Sylvain Munaut
2006-11-05 1:12 ` Benjamin Herrenschmidt
2006-11-05 1:45 ` Sylvain Munaut [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-11-11 9:53 Sylvain Munaut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=454D422B.8030003@246tNt.com \
--to=tnt@246tnt.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=sl@bplan-gmbh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).