From: Geoff Levand <geoffrey.levand@am.sony.com>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org, cbe-oss-dev@ozlabs.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [Cbe-oss-dev] [PATCH] cell: abstract spu management routines
Date: Tue, 07 Nov 2006 21:24:28 -0800 [thread overview]
Message-ID: <45516A0C.5050607@am.sony.com> (raw)
In-Reply-To: <1162962074.20271.16.camel@localhost.localdomain>
Michael Ellerman wrote:
>> +static struct platform_data *platform_data(struct spu *spu)
>> +{
>> + BUG_ON(!spu->platform_data);
>> + return (struct platform_data*)spu->platform_data;
>> +}
>
> I don't see the point of this, why not just grab platform data directly?
Well, first, it does a check, and second, you can't just grab platform_data,
you need to always do the cast also. So then, is something like
'((struct platform_data*)spu->platform_data)->' preferred over
'platform_data(spu)->'?
-Geoff
next prev parent reply other threads:[~2006-11-08 5:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-08 4:49 [PATCH] cell: abstract spu management routines Geoff Levand
2006-11-08 5:01 ` [Cbe-oss-dev] " Michael Ellerman
2006-11-08 5:24 ` Geoff Levand [this message]
2006-11-08 5:54 ` Michael Ellerman
2006-11-08 6:03 ` Geoff Levand
2006-11-08 6:06 ` Michael Ellerman
2006-11-08 6:28 ` Stephen Rothwell
2006-11-08 6:28 ` Michael Ellerman
2006-11-08 5:35 ` Benjamin Herrenschmidt
2006-11-08 5:31 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45516A0C.5050607@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=arnd@arndb.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).