From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <geoffrey.levand@am.sony.com>
Received: from mgw2.sony.co.jp (MGW2.Sony.CO.JP [137.153.0.14])
	by ozlabs.org (Postfix) with ESMTP id 0798E67CCA
	for <linuxppc-dev@ozlabs.org>; Wed,  8 Nov 2006 17:03:26 +1100 (EST)
Received: from mail3.sony.co.jp (localhost [127.0.0.1])
	by mail3.sony.co.jp (R8/Sony) with ESMTP id kA863ObC000635
	for <linuxppc-dev@ozlabs.org>; Wed, 8 Nov 2006 15:03:24 +0900 (JST)
Received: from mailgw01.scei.sony.co.jp (mailgw01.scei.sony.co.jp [43.27.73.7])
	by mail3.sony.co.jp (R8/Sony) with SMTP id kA863Ol5000618
	for <linuxppc-dev@ozlabs.org>; Wed, 8 Nov 2006 15:03:24 +0900 (JST)
Message-ID: <45517325.3090808@am.sony.com>
Date: Tue, 07 Nov 2006 22:03:17 -0800
From: Geoff Levand <geoffrey.levand@am.sony.com>
MIME-Version: 1.0
To: michael@ellerman.id.au
Subject: Re: [Cbe-oss-dev] [PATCH] cell: abstract spu management routines
References: <455161D2.3090004@am.sony.com>	
	<1162962074.20271.16.camel@localhost.localdomain>	
	<45516A0C.5050607@am.sony.com>
	<1162965270.20271.22.camel@localhost.localdomain>
In-Reply-To: <1162965270.20271.22.camel@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8
Cc: linuxppc-dev@ozlabs.org, cbe-oss-dev@ozlabs.org,
	Arnd Bergmann <arnd@arndb.de>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

Michael Ellerman wrote:
> On Tue, 2006-11-07 at 21:24 -0800, Geoff Levand wrote:
>> Michael Ellerman wrote:
>> >> +static struct platform_data *platform_data(struct spu *spu)
>> >> +{
>> >> +	BUG_ON(!spu->platform_data);
>> >> +	return (struct platform_data*)spu->platform_data;
>> >> +}
>> > 
>> > I don't see the point of this, why not just grab platform data directly?
>> 
>> Well, first, it does a check, and second, you can't just grab platform_data,
>> you need to always do the cast also. So then, is something like
>> '((struct platform_data*)spu->platform_data)->' preferred over
>> 'platform_data(spu)->'?
> 
> Yeah OK I missed the cast, I guess it's worth it then. In that case can
> you change the names? Having the struct, the member and the accessor all
> named the same is a bit confusing.
> 
> The BUG() is pretty superfluous, you're just preempting the NULL deref
> by 1 instruction.

OK, I'll do the name changes as Ben suggested.  Actually, that BUG check was
just a stale leftover from when I was getting things working :)

-Geoff