From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@osdl.org>, Nicolas DET <nd@bplan-gmbh.de>
Cc: Steve Fox <drfickle@us.ibm.com>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.19-rc5-mm1 -- ppc64 ohci-hdc.c compile failure
Date: Thu, 09 Nov 2006 15:04:13 +0000 [thread overview]
Message-ID: <4553436D.30601@shadowen.org> (raw)
In-Reply-To: <20061108015452.a2bb40d2.akpm@osdl.org>
We are seeing compile failures on ppc64 in ohci-hcd.c as below:
In file included from drivers/usb/host/ohci-hcd.c:949:
drivers/usb/host/ohci-ppc-of.c: In function `ohci_hcd_ppc_of_init':
drivers/usb/host/ohci-ppc-of.c:272: warning: int format, different type
arg (arg 2)
drivers/usb/host/ohci-ppc-of.c:272: warning: int format, different type
arg (arg 3)
drivers/usb/host/ohci-ppc-of.c: At top level:
drivers/usb/host/ohci-ppc-of.c:282: error: redefinition of `__inittest'
drivers/usb/host/ohci-pci.c:252: error: `__inittest' previously defined here
drivers/usb/host/ohci-ppc-of.c:282: error: redefinition of `init_module'
drivers/usb/host/ohci-pci.c:252: error: `init_module' previously defined
here
drivers/usb/host/ohci-ppc-of.c:283: error: redefinition of `__exittest'
drivers/usb/host/ohci-pci.c:260: error: `__exittest' previously defined here
drivers/usb/host/ohci-ppc-of.c:283: error: redefinition of `cleanup_module'
drivers/usb/host/ohci-pci.c:260: error: `cleanup_module' previously
defined here
Seems that the patch below has introduced USB_OHCI_HCD_PPC_OF enabled by
default. When it and CONFIG_USB_OHCI_HCD_PPC_SOC are enabled which
occured by default on my config then we end up with two module_init()
calls, which is illegal.
powerpc-add-of_platform-support-for-ohci-bigendian-hc
I am guessing that we are only meant to be able to have one of these
defined at a time? I changed the default to n for this and I could at
least compile the kernel, but I am sure thats not the right fix.
Nicolas?
-apw
next parent reply other threads:[~2006-11-09 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061108015452.a2bb40d2.akpm@osdl.org>
2006-11-09 15:04 ` Andy Whitcroft [this message]
2006-11-09 22:43 ` 2.6.19-rc5-mm1 -- ppc64 ohci-hdc.c compile failure Benjamin Herrenschmidt
2006-11-10 9:49 ` Paul Mackerras
2006-11-10 9:58 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4553436D.30601@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@osdl.org \
--cc=drfickle@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=nd@bplan-gmbh.de \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).