Re: [PATCH] PowerPC: clockevents and HRT support

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Paul Mackerras wrote:

>>    I think the usual rule is: "you want it, you do it". ;-)

> Sure!  And I will, at some point, if someone else doesn't do it
> first.

> My point is simply that as maintainer I won't accept a patch that
> breaks an important feature, even if it adds another important
> feature.

    It's too early to talk about the mainline acceptance of this patch ATM, 
while TOD vsyscalls are broken/removed by the GENERIC_TIME support patches 
(which are aboslutely needed for HRT as well).  We'll try to return to getting 
them straight when the time permits, but for now the HRT patchset is still in 
better form than it was for several months before that (not even compilable, 
and vsyscalls broken)...

>>    Seriously, we have neither time, not hardware, nor docs for the h/w this 
>>accounting option applies to.

> Really?  You're working on machines that don't have a timebase
> register?  What powerpc chip doesn't have a timebase register, other
> than the really old 601? :)  The timebase is all the hardware that is
> needed.

    If you look at arch/powerpc/Kconfig, you'll see that this option depends 
on PPC64 which basically says it all:  we have only 32-bit targets to care 
about ATM.  When it comes to 64-bit ones, we'll see... :-)

>>And coercing the generic clcokevents/hrtimers 
>>code into calling the arch hooks is serious design decision which I felt is 
>>better to be left to Thomas as a maintainer...

> CONFIG_VIRT_CPU_ACCOUNTING is used, and needed, on powerpc and s390,
> both of which also want to do dynticks.  If the current framework
> can't cope with that, then it needs to be extended.

    Well, why not make Linus "extend" update_process_times() for starters? :-)

> Paul.

WBR, Sergei