From: jschopp <jschopp@austin.ibm.com>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org, Nathan Lynch <ntl@pobox.com>, paulus@samba.org
Subject: Re: [PATCH]: PowerPC: make sure the rtas stop-self token is defined.
Date: Mon, 13 Nov 2006 00:21:04 -0600 [thread overview]
Message-ID: <45580ED0.7000704@austin.ibm.com> (raw)
In-Reply-To: <1163377944.7410.12.camel@localhost.localdomain>
> I can only find one caller? Is it called via a #define or something?
>
> Wouldn't it be preferable to just change rtas.h like so:
>
> #ifdef CONFIG_HOTPLUG_CPU
> extern void rtas_stop_self(void);
> #else
> static inline void rtas_stop_self(void) { }
> #endif
>
There seem to be a couple problems here. First I'm guessing the file you said there was
catting into was the online attribute, which shouldn't appear, or at least shouldn't do
anything, if cpu hotplug isn't configured. It's a stupid thing to do, but it shouldn't
crash the kernel. I guess one of us should fix that, though it probably doesn't merit
2.6.19 consideration.
The second problem is rtas_stop_self shouldn't be defined or called either. Michael's
solution above seems best for that to me. Care to give us a patch Michael?
next prev parent reply other threads:[~2006-11-13 6:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 18:22 [PATCH]: PowerPC: make sure the rtas stop-self token is defined Linas Vepstas
2006-11-10 20:01 ` Nathan Lynch
2006-11-11 1:01 ` Linas Vepstas
2006-11-13 0:32 ` Michael Ellerman
2006-11-13 6:21 ` jschopp [this message]
2006-11-13 18:05 ` Linas Vepstas
2006-11-14 1:17 ` Michael Ellerman
2006-11-15 18:08 ` Linas Vepstas
2006-11-10 23:55 ` Paul Mackerras
2006-11-11 0:52 ` Linas Vepstas
2006-11-13 18:57 ` Nathan Lynch
2006-11-13 19:39 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45580ED0.7000704@austin.ibm.com \
--to=jschopp@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=ntl@pobox.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).