linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: RTC , ds1307 I2C driver and NTP does not work.
Date: Fri, 17 Nov 2006 11:44:21 -0600	[thread overview]
Message-ID: <455DF4F5.9030201@freescale.com> (raw)
In-Reply-To: <A4DE4C29-34A0-4C57-BA16-659F89DD0D6D@kernel.crashing.org>

Kumar Gala wrote:
> On Nov 17, 2006, at 10:38 AM, Joakim Tjernlund wrote:
> 
> 
>>I get this when I activathte NTP and ntp "sync" the time the I2C HW  
>>clock.
> 
> 
> You may be better off posting this to lkml and copy the i2c list (and  
> rtc if one exists).  Since its more a driver issue than anything  
> really ppc specific.  Clearly we are doing schedules() in mpc_xfer()  
> and maybe we shouldn't be.

It's interrupt unsafe before that; rtc_set_time calls 
mutex_lock_interruptible.  If the RTC must be set from an interrupt, it 
should be via a workqueue.

-Scott

  reply	other threads:[~2006-11-17 17:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-17 16:38 RTC , ds1307 I2C driver and NTP does not work Joakim Tjernlund
2006-11-17 16:57 ` Kumar Gala
2006-11-17 17:44   ` Scott Wood [this message]
2006-11-18  0:54   ` Luong Ngo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=455DF4F5.9030201@freescale.com \
    --to=scottwood@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).