From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
npiggin@gmail.com, paulus@samba.org
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/mm: Drop VM_BUG_ON in get_region_id
Date: Sat, 18 May 2019 21:15:04 +1000 (AEST) [thread overview]
Message-ID: <455jHX4s5tz9sB8@ozlabs.org> (raw)
In-Reply-To: <20190515094523.8095-1-aneesh.kumar@linux.ibm.com>
On Wed, 2019-05-15 at 09:45:23 UTC, "Aneesh Kumar K.V" wrote:
> We can call get_region_id without validating the ea value. That means
> with a wrong ea value we hit the BUG as below.
>
> kernel BUG at arch/powerpc/include/asm/book3s/64/hash.h:129!
> Oops: Exception in kernel mode, sig: 5 [#1]
> LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries
> CPU: 0 PID: 3937 Comm: access_tests Not tainted 5.1.0
> ....
> NIP [c00000000007ba20] do_slb_fault+0x70/0x320
> LR [c00000000000896c] data_access_slb_common+0x15c/0x1a0
>
> Fix this by removing the VM_BUG_ON. All callers make sure the returned region id
> is valid and error out otherwise.
>
> Fixes: 0034d395f89d ("powerpc/mm/hash64: Map all the kernel regions in the same 0xc range")
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/6457f42eb3f6e9552366631bd5aeb096
cheers
prev parent reply other threads:[~2019-05-18 11:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 9:45 [PATCH] powerpc/mm: Drop VM_BUG_ON in get_region_id Aneesh Kumar K.V
2019-05-18 11:15 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=455jHX4s5tz9sB8@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).