linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc: fix build error in rom.c
@ 2006-12-05 23:30 Geoff Levand
  2006-12-06 12:21 ` Sergei Shtylyov
  0 siblings, 1 reply; 2+ messages in thread
From: Geoff Levand @ 2006-12-05 23:30 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: dwmw2, linuxppc-dev

Add missing include in rom.c.  Fixes this build error when CONFIG_MTD=y:

  arch/powerpc/sysdev/rom.c:26: error: implicit declaration of function of_platform_device_create

Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>

---
 arch/powerpc/sysdev/rom.c |    1 +
 1 files changed, 1 insertion(+)

--- linux-2.6.19.ppc64.orig/arch/powerpc/sysdev/rom.c
+++ linux-2.6.19.ppc64/arch/powerpc/sysdev/rom.c
@@ -9,6 +9,7 @@
 
 #include <linux/kernel.h>
 #include <asm/of_device.h>
+#include <asm/of_platform.h>
 
 static int __init powerpc_flash_init(void)
 {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc: fix build error in rom.c
  2006-12-05 23:30 [PATCH] powerpc: fix build error in rom.c Geoff Levand
@ 2006-12-06 12:21 ` Sergei Shtylyov
  0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2006-12-06 12:21 UTC (permalink / raw)
  To: Geoff Levand; +Cc: dwmw2, Paul Mackerras, linuxppc-dev

Hello.

Geoff Levand wrote:

> Add missing include in rom.c.  Fixes this build error when CONFIG_MTD=y:

>   arch/powerpc/sysdev/rom.c:26: error: implicit declaration of function of_platform_device_create

    Uh oh, that's what happens when someone doesn't respin the patches quickly 
enough. Finally, the obsolete version has been committed -- it also misses one 
property in the node spec and "reg" was called "regs" there...

> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
> 
> ---
>  arch/powerpc/sysdev/rom.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> --- linux-2.6.19.ppc64.orig/arch/powerpc/sysdev/rom.c
> +++ linux-2.6.19.ppc64/arch/powerpc/sysdev/rom.c
> @@ -9,6 +9,7 @@
>  
>  #include <linux/kernel.h>
>  #include <asm/of_device.h>
> +#include <asm/of_platform.h>
>  
>  static int __init powerpc_flash_init(void)
>  {

WBR, Sergei

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-12-06 12:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-05 23:30 [PATCH] powerpc: fix build error in rom.c Geoff Levand
2006-12-06 12:21 ` Sergei Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).