From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, i2c@lm-sensors.org
Subject: Re: [PATCH 4/4] powerpc: Call of_register_i2c_devices() for fsl-i2c.
Date: Fri, 08 Dec 2006 12:38:37 -0600 [thread overview]
Message-ID: <4579B12D.3090300@freescale.com> (raw)
In-Reply-To: <DC219401-9766-4BFD-BA94-7BA1997D9530@kernel.crashing.org>
Kumar Gala wrote:
> You are assuming the bus number is the same as our index. This may not
> be true.
http://ozlabs.org/pipermail/linuxppc-dev/2006-December/028924.html
The above patch sets the I2C ID to the index, so as long as there are no
non-SOC i2c busses with static bus numbers, it'll work.
If there are non-SOC i2c busses (such as on a PCI card) that claim a
conflicting static bus ID, there'll be problems -- but that problem
isn't powerpc or device-tree specific.
A more robust solution would be to allow each i2c adapter driver to
specify an i2c_board_info list when registering itself. The adapter
driver could then get this list from platform code (if appropriate; a
PCI card that uses i2c internally would simply have its own list),
without having to deal with system-wide bus IDs.
-Scott
next prev parent reply other threads:[~2006-12-08 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 17:35 [PATCH 4/4] powerpc: Call of_register_i2c_devices() for fsl-i2c Scott Wood
2006-12-07 19:35 ` Arnd Bergmann
2006-12-07 19:39 ` Kumar Gala
2006-12-07 22:05 ` Kumar Gala
2006-12-08 18:38 ` Scott Wood [this message]
2006-12-08 20:34 ` Kumar Gala
2006-12-08 22:54 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4579B12D.3090300@freescale.com \
--to=scottwood@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=i2c@lm-sensors.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).