linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, i2c@lm-sensors.org
Subject: Re: [PATCH 4/4] powerpc: Call of_register_i2c_devices() for fsl-i2c.
Date: Fri, 08 Dec 2006 16:54:23 -0600	[thread overview]
Message-ID: <4579ED1F.5050205@freescale.com> (raw)
In-Reply-To: <FDE06AFE-E8B2-4507-99DA-2B8765AFA5B8@kernel.crashing.org>

Kumar Gala wrote:
> What about doing the of_register_i2c_devices in the fsl-i2c driver  
> itself.  Than it knows what bus number its been assigned.

It won't know the dynamic bus number until after it registers the 
adapter, which is too late (even if the new-style device registration 
were modified to support registering devices after adapter registration, 
legacy probing drivers for devices on the same address might grab the 
device first, before the proper device gets registered).

The allocation of an i2c bus ID could be factored out into its own 
function that gets called before registering the i2c adapter.  This 
(plus calling of_register_i2c_devices in the adapter driver) isn't much 
different from passing the list in with the adapter registration, but it 
would avoid some list management.  OTOH, it means we'd have to continue 
having global numeric bus IDs even after the last legacy driver is 
converted.

-Scott

      reply	other threads:[~2006-12-08 22:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-07 17:35 [PATCH 4/4] powerpc: Call of_register_i2c_devices() for fsl-i2c Scott Wood
2006-12-07 19:35 ` Arnd Bergmann
2006-12-07 19:39   ` Kumar Gala
2006-12-07 22:05 ` Kumar Gala
2006-12-08 18:38   ` Scott Wood
2006-12-08 20:34     ` Kumar Gala
2006-12-08 22:54       ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4579ED1F.5050205@freescale.com \
    --to=scottwood@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=i2c@lm-sensors.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).