From: Corey Minyard <minyard@acm.org>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Christian Krafft <krafft@linux.ibm.com>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Christian Krafft <krafft@de.ibm.com>,
openipmi-developer@lists.sourceforge.net
Subject: Re: [patch 0/1] ipmi: update: add autosensing of ipmi devices on powerpc using of device tree
Date: Tue, 19 Dec 2006 12:01:55 -0600 [thread overview]
Message-ID: <45882913.2000609@acm.org> (raw)
In-Reply-To: <33A5A5AA-3ECF-474E-90D4-584EEA7F37AD@kernel.crashing.org>
Segher Boessenkool wrote:
>>> info->io_regsize = regsize ? *regsize : DEFAULT_REGSIZE;
>>>
>>> [Please note that fixes a copy/paste bug, too].
>>
>> There is no DEFAULT_REGSIZE, all the code is using DEFAULT_REGSPACING
>> as the default size.
>> It looks like the code assumes that the registers are located next to
>> each other.
>
> It would be more logical to only use REGSIZE then, heh.
>
>> If thats not good, DEFAULT_REGSIZE should be introduced and used in
>> all other probe functions as well.
>> That would be a seperate issue .
>
> You could start the cleanup by doing
>
> #define DEFAULT_REGSIZE DEFAULT_REGSPACING
>
> and using REGSIZE in the new code. Or replace s/REGSPACING/REGSIZE/
> throughout. Or something.
>
> Not your fault though, just leave it as-is if you don't feel
> like fixing others' mess :-)
Doing this is fine with me, it needs to be done.
-Corey
next prev parent reply other threads:[~2006-12-19 18:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061218163846.337fed65@localhost>
2006-12-18 15:42 ` [patch 0/1] ipmi: update: add autosensing of ipmi devices on powerpc using of device tree Christian Krafft
2006-12-18 21:52 ` Segher Boessenkool
2006-12-18 22:23 ` Arnd Bergmann
2006-12-19 17:48 ` Segher Boessenkool
2006-12-19 18:06 ` [Openipmi-developer] " Corey Minyard
2006-12-19 13:12 ` Christian Krafft
2006-12-19 17:52 ` Segher Boessenkool
2006-12-19 18:01 ` Corey Minyard [this message]
2006-12-20 14:45 ` [patch 0/1] updated version Christian Krafft
2006-12-21 0:11 ` Arnd Bergmann
2007-01-24 23:45 ` [patch 1/1] updated version, fixed the compiler warning Christian Krafft
2007-01-24 23:56 ` Benjamin Herrenschmidt
2007-01-25 0:29 ` Segher Boessenkool
2007-01-25 0:45 ` Christian Krafft
2007-01-25 0:45 ` Benjamin Herrenschmidt
2007-01-25 1:05 ` Segher Boessenkool
2007-01-25 3:14 ` Arnd Bergmann
2007-01-25 0:24 ` Segher Boessenkool
2007-01-25 3:30 ` [patch 0/1] next updated version, fixed cleanup and some minors Christian Krafft
2007-01-25 3:34 ` [patch 1/1] " Christian Krafft
2007-01-25 5:19 ` Arnd Bergmann
2007-01-29 3:49 ` [Openipmi-developer] " Corey Minyard
2007-01-26 2:54 ` [patch 1/1] updated version, fixed the compiler warning Christoph Hellwig
2007-01-26 4:23 ` Arnd Bergmann
2007-01-28 23:07 ` Christian Krafft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45882913.2000609@acm.org \
--to=minyard@acm.org \
--cc=arnd@arndb.de \
--cc=krafft@de.ibm.com \
--cc=krafft@linux.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).