linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Add a device_initcall to call	of_platform_bus_probe on all fsl SoCs
Date: Tue, 19 Dec 2006 18:10:13 -0600	[thread overview]
Message-ID: <45887F65.1020603@freescale.com> (raw)
In-Reply-To: <1166571629.19254.90.camel@localhost.localdomain>

Benjamin Herrenschmidt wrote:
> What cores do those chip use ? Any reason why one couldn't build a
> kernel that boots those chips -and- chrp,pmac,etc... in one image ?
> 
> If that is the case, then your initcall will incorrectly be called on
> platforms that don't need it.

It won't do anything, though, unless it finds a node that matches 
of_default_bus_ids.  Are there any platforms on which "soc" nodes (or 
others in the default list) shouldn't be probed?  If not, perhaps make a 
generic initcall to of_platform_bus_probe(), so that it won't be called 
multiple times by different SoC types that are in the same kernel?

Otherwise, perhaps the SoCs could be given "fsl-soc" in their compatible 
field, and have fsl_publish_devices() pass that as a match struct.

> I think what we need to do is to define a mecanism for board initcalls.
> 
> Something like board_xxx_initcall(boardname, function);

It's not really a board-level issue, though -- at most, it's SoC-level.

-Scott

  reply	other threads:[~2006-12-20  0:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-19 21:31 [PATCH] powerpc: Add a device_initcall to call of_platform_bus_probe on all fsl SoCs Kim Phillips
2006-12-19 23:00 ` Benjamin Herrenschmidt
2006-12-19 23:22   ` Kim Phillips
2006-12-19 23:40     ` Benjamin Herrenschmidt
2006-12-20  0:10       ` Scott Wood [this message]
2006-12-20  0:19         ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45887F65.1020603@freescale.com \
    --to=scottwood@freescale.com \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).