From: Scott Wood <scottwood@freescale.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 06/18] bootwrapper: Make ft_get_phandle() accept and return NULL.
Date: Tue, 30 Jan 2007 13:51:20 -0600 [thread overview]
Message-ID: <45BFA1B8.7050203@freescale.com> (raw)
In-Reply-To: <C6B564EE-CF80-45E7-868B-28A43EDED755@kernel.crashing.org>
Segher Boessenkool wrote:
>> Currently, if ft_get_phandle() is passed NULL it will allocate an entry
>> for it and return a non-NULL phandle. This patch makes it simply pass
>> the NULL through.
>
>
> Seems like an obvious bug fix to me -- I assume you
> audited all callers? Although I can't imagine
> anything relying on such weird behaviour ;-)
The only caller that existed before my patches was ft_find_device(),
which was only used to implement dt_ops.finddevice().
-Scott
next prev parent reply other threads:[~2007-01-30 19:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ca1ac163-f732-45ce-9629-e6f4a8c3a880@ld0162-tx32.am.freescale.net>
2007-01-29 20:11 ` [PATCH 02/18] bootwrapper: Set -msoft-float and assembler target options Scott Wood
2007-01-29 20:40 ` Scott Wood
2007-01-30 19:42 ` Segher Boessenkool
2007-01-29 20:11 ` [PATCH 03/18] bootwrapper: Remove OF-isms Scott Wood
2007-01-29 20:11 ` [PATCH 04/18] bootwrapper: Add ft_root_node() Scott Wood
2007-01-30 19:44 ` Segher Boessenkool
2007-01-29 20:11 ` [PATCH 05/18] bootwrapper: Rename ft_node_add() to ft_get_phandle() Scott Wood
2007-01-29 20:12 ` [PATCH 06/18] bootwrapper: Make ft_get_phandle() accept and return NULL Scott Wood
2007-01-30 19:48 ` Segher Boessenkool
2007-01-30 19:51 ` Scott Wood [this message]
2007-01-29 20:12 ` [PATCH 07/18] bootwrapper: Preserve the pp pointer in ft_make_space() when calling ft_reorder() Scott Wood
2007-01-29 20:12 ` [PATCH 08/18] bootwrapper: Modify *pp, not *p, in ft_shuffle() Scott Wood
2007-01-30 19:49 ` Segher Boessenkool
2007-01-29 20:12 ` [PATCH 09/18] bootwrapper: Use map_string() instead of lookup_string() in ft_prop() Scott Wood
2007-01-29 20:12 ` [PATCH 10/18] bootwrapper: Add ft_find_device_rel() Scott Wood
2007-01-30 19:53 ` Segher Boessenkool
2007-01-30 20:25 ` Scott Wood
2007-01-29 20:12 ` [PATCH 11/18] bootwrapper: Refactor ft_get_prop() into internal and external functions Scott Wood
2007-01-29 20:12 ` [PATCH 12/18] bootwrapper: Make ft_get_parent() return a phandle, and NULL if already top-level Scott Wood
2007-01-30 19:56 ` Segher Boessenkool
2007-01-30 20:39 ` Scott Wood
2007-01-29 20:13 ` [PATCH 13/18] bootwrapper: Add ft_find_prop() Scott Wood
2007-01-30 19:57 ` Segher Boessenkool
2007-01-29 20:13 ` [PATCH 14/18] bootwrapper: Add initrd information to the device tree in ft_finalize() Scott Wood
2007-01-29 20:13 ` [PATCH 15/18] bootwrapper: Make ft_create_node() pay attention to the parent parameter Scott Wood
2007-01-29 20:13 ` [PATCH 16/18] bootwrapper: Add dt_ops methods Scott Wood
2007-01-30 20:01 ` Segher Boessenkool
2007-01-31 7:02 ` David Gibson
2007-01-29 20:13 ` [PATCH 17/18] bootwrapper: Add xlate_reg(), and use it to find serial registers Scott Wood
2007-01-29 20:13 ` [PATCH 18/18] bootwrapper: Compatibility layer for old U-Boots (a.k.a. cuImage, cuboot) Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BFA1B8.7050203@freescale.com \
--to=scottwood@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).