From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de01egw02.freescale.net (de01egw02.freescale.net [192.88.165.103]) by ozlabs.org (Postfix) with ESMTP id AAAD5DE209 for ; Wed, 31 Jan 2007 06:51:32 +1100 (EST) Message-ID: <45BFA1B8.7050203@freescale.com> Date: Tue, 30 Jan 2007 13:51:20 -0600 From: Scott Wood MIME-Version: 1.0 To: Segher Boessenkool Subject: Re: [PATCH 06/18] bootwrapper: Make ft_get_phandle() accept and return NULL. References: <20070129201201.GF13485@ld0162-tx32.am.freescale.net> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Segher Boessenkool wrote: >> Currently, if ft_get_phandle() is passed NULL it will allocate an entry >> for it and return a non-NULL phandle. This patch makes it simply pass >> the NULL through. > > > Seems like an obvious bug fix to me -- I assume you > audited all callers? Although I can't imagine > anything relying on such weird behaviour ;-) The only caller that existed before my patches was ft_find_device(), which was only used to implement dt_ops.finddevice(). -Scott