linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/3] 8349emds default dts updates for USB change
@ 2007-02-05  9:10 Li Yang
  2007-02-05 15:06 ` Kumar Gala
  0 siblings, 1 reply; 4+ messages in thread
From: Li Yang @ 2007-02-05  9:10 UTC (permalink / raw)
  To: Paul; +Cc: linuxppc-dev

Signed-off-by: Li Yang <leoli@freescale.com>
---
 arch/powerpc/boot/dts/mpc8349emds.dts |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc8349emds.dts b/arch/powerpc/boot/dts/mpc8349emds.dts
index efceb34..ba31af1 100644
--- a/arch/powerpc/boot/dts/mpc8349emds.dts
+++ b/arch/powerpc/boot/dts/mpc8349emds.dts
@@ -39,6 +39,11 @@
 		reg = <00000000 10000000>;	// 256MB at 0
 	};
 
+	bcsr@f8000000 {
+		device_type = "board-control";
+		reg = <e2400000 8000>;
+	};
+
 	soc8349@e0000000 {
 		#address-cells = <1>;
 		#size-cells = <1>;
@@ -103,6 +108,7 @@
 			#size-cells = <0>;
 			interrupt-parent = <700>;
 			interrupts = <26 2>;
+			dr_mode = "otg";
 			phy_type = "ulpi";
 		};
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 3/3] 8349emds default dts updates for USB change
  2007-02-05  9:10 [PATCH 3/3] 8349emds default dts updates for USB change Li Yang
@ 2007-02-05 15:06 ` Kumar Gala
  2007-02-06  3:17   ` Li Yang-r58472
  0 siblings, 1 reply; 4+ messages in thread
From: Kumar Gala @ 2007-02-05 15:06 UTC (permalink / raw)
  To: Li Yang; +Cc: linuxppc-dev, Paul


On Feb 5, 2007, at 3:10 AM, Li Yang wrote:

> Signed-off-by: Li Yang <leoli@freescale.com>
> ---
> arch/powerpc/boot/dts/mpc8349emds.dts |    6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc8349emds.dts b/arch/powerpc/ 
> boot/dts/mpc8349emds.dts
> index efceb34..ba31af1 100644
> --- a/arch/powerpc/boot/dts/mpc8349emds.dts
> +++ b/arch/powerpc/boot/dts/mpc8349emds.dts
> @@ -39,6 +39,11 @@
> 		reg = <00000000 10000000>;	// 256MB at 0
> 	};
> +	bcsr@f8000000 {
> +		device_type = "board-control";
> +		reg = <e2400000 8000>;

Are the bcsr's at f8000000 or e2400000?

> +	};
> +
> 	soc8349@e0000000 {
> 		#address-cells = <1>;
> 		#size-cells = <1>;
> @@ -103,6 +108,7 @@
> 			#size-cells = <0>;
> 			interrupt-parent = <700>;
> 			interrupts = <26 2>;
> +			dr_mode = "otg";

You're introducing a new property without any Documentation  
describing it.

> 			phy_type = "ulpi";
> 		};

- k

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH 3/3] 8349emds default dts updates for USB change
  2007-02-05 15:06 ` Kumar Gala
@ 2007-02-06  3:17   ` Li Yang-r58472
  2007-02-06  3:31     ` Kumar Gala
  0 siblings, 1 reply; 4+ messages in thread
From: Li Yang-r58472 @ 2007-02-06  3:17 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev, Paul

> -----Original Message-----
> From: Kumar Gala [mailto:galak@kernel.crashing.org]
> Sent: Monday, February 05, 2007 11:07 PM
> To: Li Yang-r58472
> Cc: Paul; linuxppc-dev@ozlabs.org
> Subject: Re: [PATCH 3/3] 8349emds default dts updates for USB change
>=20
>=20
> On Feb 5, 2007, at 3:10 AM, Li Yang wrote:
>=20
> > Signed-off-by: Li Yang <leoli@freescale.com>
> > ---
> > arch/powerpc/boot/dts/mpc8349emds.dts |    6 ++++++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/powerpc/boot/dts/mpc8349emds.dts b/arch/powerpc/
> > boot/dts/mpc8349emds.dts
> > index efceb34..ba31af1 100644
> > --- a/arch/powerpc/boot/dts/mpc8349emds.dts
> > +++ b/arch/powerpc/boot/dts/mpc8349emds.dts
> > @@ -39,6 +39,11 @@
> > 		reg =3D <00000000 10000000>;	// 256MB at 0
> > 	};
> > +	bcsr@f8000000 {
> > +		device_type =3D "board-control";
> > +		reg =3D <e2400000 8000>;
>=20
> Are the bcsr's at f8000000 or e2400000?

According to the default u-boot configuration in tree, it is e2400000.

- Leo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 3/3] 8349emds default dts updates for USB change
  2007-02-06  3:17   ` Li Yang-r58472
@ 2007-02-06  3:31     ` Kumar Gala
  0 siblings, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2007-02-06  3:31 UTC (permalink / raw)
  To: Li Yang-r58472; +Cc: linuxppc-dev, Paul


On Feb 5, 2007, at 9:17 PM, Li Yang-r58472 wrote:

>> -----Original Message-----
>> From: Kumar Gala [mailto:galak@kernel.crashing.org]
>> Sent: Monday, February 05, 2007 11:07 PM
>> To: Li Yang-r58472
>> Cc: Paul; linuxppc-dev@ozlabs.org
>> Subject: Re: [PATCH 3/3] 8349emds default dts updates for USB change
>>
>>
>> On Feb 5, 2007, at 3:10 AM, Li Yang wrote:
>>
>>> Signed-off-by: Li Yang <leoli@freescale.com>
>>> ---
>>> arch/powerpc/boot/dts/mpc8349emds.dts |    6 ++++++
>>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/powerpc/boot/dts/mpc8349emds.dts b/arch/powerpc/
>>> boot/dts/mpc8349emds.dts
>>> index efceb34..ba31af1 100644
>>> --- a/arch/powerpc/boot/dts/mpc8349emds.dts
>>> +++ b/arch/powerpc/boot/dts/mpc8349emds.dts
>>> @@ -39,6 +39,11 @@
>>> 		reg = <00000000 10000000>;	// 256MB at 0
>>> 	};
>>> +	bcsr@f8000000 {
>>> +		device_type = "board-control";
>>> +		reg = <e2400000 8000>;
>>
>> Are the bcsr's at f8000000 or e2400000?
>
> According to the default u-boot configuration in tree, it is e2400000.

Fine, so what is it bcsr@f8000000?

- k

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-02-06  3:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-05  9:10 [PATCH 3/3] 8349emds default dts updates for USB change Li Yang
2007-02-05 15:06 ` Kumar Gala
2007-02-06  3:17   ` Li Yang-r58472
2007-02-06  3:31     ` Kumar Gala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).