linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Mike Strosaker <strosake@austin.ibm.com>
Cc: Olof Johansson <olof@lixom.net>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Update udbg_progress() to display the integer
Date: Wed, 07 Feb 2007 10:28:32 -0600	[thread overview]
Message-ID: <45C9FE30.8010108@freescale.com> (raw)
In-Reply-To: <45C97121.9080609@austin.ibm.com>

Mike Strosaker wrote:

> The op panel on recent systems has 2 lines; the first can display 16 
> characters, the second, 80.  The first line is usually used to display 
> an 8 character hexadecimal progress/error message (called an SRC: System 
> Reference Code), and the second line is used to display a location code 
> when appropriate (e.g. when the SRC indicates a device failure).  IBM 
> documents many of their OF and RTAS SRCs deep in the Hardware 
> Information Center:

In that case, the big question is: does the kernel conform to this standard? 
Looking at the current usage of ppc_md.progress(), I can't help but think that 
it being called the same way printk() is being called, i.e. at the whim of the 
developer who wrote the code.

So let's say that we need to keep ppc_md.progress().  I think we should have 
some way of restricting its usage to systems where it does something different 
than printk().  On an Freescale 83xx reference board, for example, its output 
goes to the same place as printk(), so it doesn't serve any purpose.

Perhaps we should define ppc_md.progress() such that it never sends the output 
to the same place as printk().  If the only output device is the serial port, 
and printk() already outputs there, then ppc_md.progress() should do nothing. 
This would eliminate any "accidental" use of ppc_md.progress(), when printk() is 
the better choice.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

  reply	other threads:[~2007-02-07 16:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-05 19:51 [PATCH] Update udbg_progress() to display the integer Timur Tabi
2007-02-06  1:30 ` Olof Johansson
2007-02-06 23:08   ` Timur Tabi
2007-02-06 23:11     ` Paul Mackerras
2007-02-06 23:38       ` Benjamin Herrenschmidt
2007-02-06 23:41         ` Kumar Gala
2007-02-06 23:54           ` Timur Tabi
2007-02-07  0:03             ` Olof Johansson
2007-02-07  0:04               ` Timur Tabi
2007-02-07 21:59                 ` Linas Vepstas
2007-02-07 22:26                   ` Timur Tabi
2007-02-07  0:00           ` Stephen Rothwell
2007-02-07  0:04             ` Stephen Rothwell
2007-02-06 23:42         ` Timur Tabi
2007-02-07  6:26           ` Mike Strosaker
2007-02-07 16:28             ` Timur Tabi [this message]
2007-02-08  0:31               ` Michael Ellerman
2007-02-08  2:07                 ` Timur Tabi
2007-02-07 21:03             ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C9FE30.8010108@freescale.com \
    --to=timur@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olof@lixom.net \
    --cc=paulus@samba.org \
    --cc=strosake@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).