From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de01egw01.freescale.net (de01egw01.freescale.net [192.88.165.102]) by ozlabs.org (Postfix) with ESMTP id 9478FDDE46 for ; Wed, 14 Feb 2007 04:25:05 +1100 (EST) Message-ID: <45D1F46C.4050901@freescale.com> Date: Tue, 13 Feb 2007 11:25:00 -0600 From: Timur Tabi MIME-Version: 1.0 To: paulus@samba.org Subject: Re: [PATCH] Check mac-address first in fsl_soc.c References: <11710513671236-git-send-email-timur@freescale.com> <45CCDEFB.5050504@ru.mvista.com> <45CCDFBC.1090104@freescale.com> <45CCE07F.9040107@ru.mvista.com> In-Reply-To: <45CCE07F.9040107@ru.mvista.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sergei Shtylyov wrote: > I'm mainly concerned about 85xx. I guess the needed change should be > very alike... I've submitted U-Boot patches for 83xx, 85xx, 86xx, and 5xxx to the maintainers. You'll have to ask them when the patches will be applied. >> I wanted to keep my patch simple. > > That's clearly an over-simplification to repeat the same code thrice. Actually, the 2nd and third instances are conditionally compiled, so in most cases only one instance of the code will actually be compiled. gfar_of_init() should probably also be conditionally compiled, so if I make it a separate function, I'd have to prefix it with something like this: #if defined(CONFIG_GIANFAR) || defined(CONFIG_CPM2) || defined(CONFIG_8xx) and then I would need to pass a bunch of parameters. I don't really think that's an improvement. Paul, if there are no serious objections, please apply this patch. -- Timur Tabi Linux Kernel Developer @ Freescale