From: Timur Tabi <timur@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Check mac-address first in fsl_soc.c
Date: Tue, 13 Feb 2007 15:23:04 -0600 [thread overview]
Message-ID: <45D22C38.10803@freescale.com> (raw)
In-Reply-To: <45D21688.8090009@freescale.com>
Timur Tabi wrote:
> I just had an idea. The mac-address change should really be extended to all
> OF-enabled Ethernet drivers. How about I put get_mac_address() in
> arch/powerpc/kernel/prom.c, right after get_property(), instead of making it an
> inline function just for fsl_soc.c?
Hmmm... if I do that, then get_mac_address() is no longer an init-only function.
That probably is a good thing, because then device trees can call it when
they're loaded. In that case, should I make null_mac_address[] static again?
And what about the name? Should I call it of_get_mac_address()? Plain old
"get_mac_address" sounds like a namespace collision waiting to happen.
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2007-02-13 21:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 20:02 [PATCH] Check mac-address first in fsl_soc.c Timur Tabi
2007-02-09 20:52 ` Sergei Shtylyov
2007-02-09 20:55 ` Timur Tabi
2007-02-09 20:58 ` Sergei Shtylyov
2007-02-09 21:00 ` Timur Tabi
2007-02-09 21:06 ` Kumar Gala
2007-02-09 21:09 ` Timur Tabi
2007-02-13 17:25 ` Timur Tabi
2007-02-13 17:33 ` Sergei Shtylyov
2007-02-13 17:37 ` Timur Tabi
2007-02-13 17:37 ` Kumar Gala
2007-02-13 17:45 ` Timur Tabi
2007-02-13 18:01 ` Kumar Gala
2007-02-13 18:51 ` Timur Tabi
2007-02-13 19:01 ` Kumar Gala
2007-02-13 19:10 ` Timur Tabi
2007-02-13 19:20 ` Timur Tabi
2007-02-13 19:50 ` Timur Tabi
2007-02-13 21:23 ` Timur Tabi [this message]
2007-02-13 22:14 ` Kumar Gala
2007-02-09 21:24 ` Jerry Van Baren
2007-02-09 21:51 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D22C38.10803@freescale.com \
--to=timur@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).