From: Timur Tabi <timur@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] powerpc: add of_get_mac_address() and update fsl_soc.c to use it
Date: Tue, 13 Feb 2007 23:17:52 -0600 [thread overview]
Message-ID: <45D29B80.2060705@freescale.com> (raw)
In-Reply-To: <1171411219.20192.118.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
>> + return get_property(np, "address", NULL);
>
> Since there is so much room for confusion with "address", please at
> least do some basic sanity checking, like check that it's size is 6
> bytes and maybe that the multicast bit isn't set.
Are you saying that some device trees have something *other* than a MAC
address in the 'address' property?
next prev parent reply other threads:[~2007-02-14 5:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 23:10 [PATCH] powerpc: add of_get_mac_address() and update fsl_soc.c to use it Timur Tabi
2007-02-14 0:00 ` Benjamin Herrenschmidt
2007-02-14 0:21 ` Olof Johansson
2007-02-14 5:17 ` Timur Tabi [this message]
2007-02-14 5:28 ` Benjamin Herrenschmidt
2007-02-14 5:30 ` Timur Tabi
2007-02-14 14:09 ` Sergei Shtylyov
2007-02-15 20:47 ` Segher Boessenkool
2007-02-15 20:55 ` Timur Tabi
2007-02-16 13:25 ` Segher Boessenkool
2007-02-16 14:38 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D29B80.2060705@freescale.com \
--to=timur@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).