From: Timur Tabi <timur@freescale.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v3] powerpc: add of_get_mac_address() and update fsl_soc.c to use it
Date: Fri, 16 Feb 2007 08:41:22 -0600 [thread overview]
Message-ID: <45D5C292.2080904@freescale.com> (raw)
In-Reply-To: <17876.64475.232797.997009@cargo.ozlabs.ibm.com>
Paul Mackerras wrote:
> Timur Tabi writes:
>
>> Add function of_get_mac_address(), which obtains the best MAC address to use
>> from the device tree by checking various properties in order. The order is:
>> 'mac-address', then 'local-mac-address', then 'address'. It skips properties
>> that contain invalid MAC addresses, which were probably not initialized
>> by U-Boot.
>
> Looks OK except that of_get_mac_address should go in prom_parse.c, not
> prom.c.
Ok, I'll submit another patch in a few hours. I presume the prototype
should stay in include/asm-powerpc/prom.h?
prev parent reply other threads:[~2007-02-16 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-14 17:54 [PATCH v3] powerpc: add of_get_mac_address() and update fsl_soc.c to use it Timur Tabi
2007-02-16 0:33 ` Paul Mackerras
2007-02-16 14:41 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D5C292.2080904@freescale.com \
--to=timur@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).