[PATCH] mpc52xx_pic: fix main interrupt masking

[PATCH] mpc52xx_pic: fix main interrupt masking

[Domen Puncer]

Fix main interrupt masking.
Tested with RTC and GPIO_WKUP interrupts.


Signed-off-by: Domen Puncer <domen.puncer@telargo.com>

---
 arch/powerpc/platforms/52xx/mpc52xx_pic.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: grant.git/arch/powerpc/platforms/52xx/mpc52xx_pic.c
===================================================================
--- grant.git.orig/arch/powerpc/platforms/52xx/mpc52xx_pic.c
+++ grant.git/arch/powerpc/platforms/52xx/mpc52xx_pic.c
@@ -128,7 +128,7 @@ static void mpc52xx_main_mask(unsigned i
 
 	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
 
-	io_be_setbit(&intr->main_mask, 15 - l2irq);
+	io_be_setbit(&intr->main_mask, 16 - l2irq);
 }
 
 static void mpc52xx_main_unmask(unsigned int virq)
@@ -141,7 +141,7 @@ static void mpc52xx_main_unmask(unsigned
 
 	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
 
-	io_be_clrbit(&intr->main_mask, 15 - l2irq);
+	io_be_clrbit(&intr->main_mask, 16 - l2irq);
 }
 
 static struct irq_chip mpc52xx_main_irqchip = {

Re: [PATCH] mpc52xx_pic: fix main interrupt masking

[Sylvain Munaut]

Domen Puncer wrote:
> Fix main interrupt masking.
> Tested with RTC and GPIO_WKUP interrupts.
>
>
> Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
>   
Acked-by: Sylvain Munaut <tnt@246tNt.com>

Damn, I knew I forgot something during the last batch ! That bug had
already been spotted earlier ...

> ---
>  arch/powerpc/platforms/52xx/mpc52xx_pic.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: grant.git/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> ===================================================================
> --- grant.git.orig/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> +++ grant.git/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> @@ -128,7 +128,7 @@ static void mpc52xx_main_mask(unsigned i
>  
>  	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
>  
> -	io_be_setbit(&intr->main_mask, 15 - l2irq);
> +	io_be_setbit(&intr->main_mask, 16 - l2irq);
>  }
>  
>  static void mpc52xx_main_unmask(unsigned int virq)
> @@ -141,7 +141,7 @@ static void mpc52xx_main_unmask(unsigned
>  
>  	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
>  
> -	io_be_clrbit(&intr->main_mask, 15 - l2irq);
> +	io_be_clrbit(&intr->main_mask, 16 - l2irq);
>  }
>  
>  static struct irq_chip mpc52xx_main_irqchip = {
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
>
>