linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org,
	Phillips Kim-R1AAHA <Kim.Phillips@freescale.com>
Subject: Re: [PATCH][POWERPC] QE: Make QUICC Engine support a configurableoption
Date: Thu, 15 Mar 2007 11:51:41 -0500	[thread overview]
Message-ID: <45F9799D.7080206@freescale.com> (raw)
In-Reply-To: <20070315164728.GA20524@ld0162-tx32.am.freescale.net>

Scott Wood wrote:

>> +config QUICC_ENGINE_83xx
>> +	bool "QUICC Engine Support"
>> +	select QUICC_ENGINE
>> +	depends on PPC_MPC836x || PPC_MPC832x
>> +	default y
>> +	---help---
>> +	  The QUICC Engine (QE) is a new generation of communications
>> +	  coprocessors on Freescale embedded CPUs (akin to CPM in older chips).
>> +	  Selecting this option means that you wish to build a kernel
>> +	  for a machine with a QE coprocessor.
>> +
> 
> Instead of doing it like this, what about having each QE-enabled SOC
> select HAS_QUICC_ENGINE, and then have the user-configurable
> QUICC_ENGINE option depend on HAS_QUICC_ENGINE?

The purpose of doing it this way is that the "QE Support" option appears 
BELOW each SOC option.  So if you pick an 836x, you'll see a menu that 
says "QE support".  You want to have the menu option to disable QE 
support even if the QE is present on the SOC.

We will need to do the same thing with the 8568, when the QE support 
works with it.  At that point, there will be a "QUICC_ENGINE_85xx", 
which will appear on *that* menu.

You cannot have the same config option in more than one Kconfig file.

  reply	other threads:[~2007-03-15 16:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-14 18:15 [PATCH][POWERPC] QE: Make QUICC Engine support a configurable option Kumar Gala
2007-03-14 18:37 ` Kim Phillips
2007-03-14 19:36   ` Timur Tabi
2007-03-15  3:02     ` [PATCH][POWERPC] QE: Make QUICC Engine support a configurableoption Li Yang-r58472
2007-03-15  3:49       ` Kumar Gala
2007-03-15  5:39         ` Li Yang-r58472
2007-03-15  5:40           ` Kumar Gala
2007-03-15  6:29             ` Li Yang-r58472
2007-03-15 13:04               ` Timur Tabi
2007-03-15 15:07                 ` Kumar Gala
2007-03-15 16:47                   ` Scott Wood
2007-03-15 16:51                     ` Timur Tabi [this message]
2007-03-16 19:21                   ` Timur Tabi
2007-03-16 19:44                     ` Kumar Gala
2007-03-16 20:16                       ` Timur Tabi
2007-03-16 19:47                   ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45F9799D.7080206@freescale.com \
    --to=timur@freescale.com \
    --cc=Kim.Phillips@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).