* [PATCH -next] misc: ocxl: Make ocxl_remove static
@ 2019-05-04 10:27 YueHaibing
2019-05-05 14:21 ` Andrew Donnellan
2019-06-03 12:32 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-05-04 10:27 UTC (permalink / raw)
To: fbarrat, ajd, arnd, gregkh; +Cc: YueHaibing, linuxppc-dev, linux-kernel
Fix sparse warning:
drivers/misc/ocxl/pci.c:44:6: warning:
symbol 'ocxl_remove' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/misc/ocxl/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/ocxl/pci.c b/drivers/misc/ocxl/pci.c
index f2a3ef4..cb920aa 100644
--- a/drivers/misc/ocxl/pci.c
+++ b/drivers/misc/ocxl/pci.c
@@ -41,7 +41,7 @@ static int ocxl_probe(struct pci_dev *dev, const struct pci_device_id *id)
return 0;
}
-void ocxl_remove(struct pci_dev *dev)
+static void ocxl_remove(struct pci_dev *dev)
{
struct ocxl_fn *fn;
struct ocxl_afu *afu;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] misc: ocxl: Make ocxl_remove static
2019-05-04 10:27 [PATCH -next] misc: ocxl: Make ocxl_remove static YueHaibing
@ 2019-05-05 14:21 ` Andrew Donnellan
2019-06-03 12:32 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Donnellan @ 2019-05-05 14:21 UTC (permalink / raw)
To: YueHaibing, fbarrat, arnd, gregkh; +Cc: linuxppc-dev, linux-kernel
On 4/5/19 8:27 pm, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/misc/ocxl/pci.c:44:6: warning:
> symbol 'ocxl_remove' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Good catch!
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
> ---
> drivers/misc/ocxl/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/ocxl/pci.c b/drivers/misc/ocxl/pci.c
> index f2a3ef4..cb920aa 100644
> --- a/drivers/misc/ocxl/pci.c
> +++ b/drivers/misc/ocxl/pci.c
> @@ -41,7 +41,7 @@ static int ocxl_probe(struct pci_dev *dev, const struct pci_device_id *id)
> return 0;
> }
>
> -void ocxl_remove(struct pci_dev *dev)
> +static void ocxl_remove(struct pci_dev *dev)
> {
> struct ocxl_fn *fn;
> struct ocxl_afu *afu;
>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] misc: ocxl: Make ocxl_remove static
2019-05-04 10:27 [PATCH -next] misc: ocxl: Make ocxl_remove static YueHaibing
2019-05-05 14:21 ` Andrew Donnellan
@ 2019-06-03 12:32 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2019-06-03 12:32 UTC (permalink / raw)
To: YueHaibing, fbarrat, ajd, arnd, gregkh
Cc: linuxppc-dev, YueHaibing, linux-kernel
On Sat, 2019-05-04 at 10:27:20 UTC, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/misc/ocxl/pci.c:44:6: warning:
> symbol 'ocxl_remove' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/00b0cdbbc87fb4b531a0d75f4004ed3d
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-03 12:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-04 10:27 [PATCH -next] misc: ocxl: Make ocxl_remove static YueHaibing
2019-05-05 14:21 ` Andrew Donnellan
2019-06-03 12:32 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).